replace panics with logging

imgbom/analyzer/dpkg/analyzer.go

@@ -4,6 +4,7 @@ import (
 	"strings"
 
 	"github.com/anchore/imgbom/imgbom/pkg"
+	"github.com/anchore/imgbom/internal/log"
 	"github.com/anchore/stereoscope/pkg/file"
 	"github.com/anchore/stereoscope/pkg/tree"
 )
@@ -16,6 +17,10 @@ func NewAnalyzer() *Analyzer {
 	return &Analyzer{}
 }
 
+func (a *Analyzer) Name() string {
+	return "dpkg-analyzer"
+}
+
 func (a *Analyzer) SelectFiles(trees []*tree.FileTree) []file.Reference {
 	files := make([]file.Reference, 0)
 	for _, tree := range trees {
@@ -36,14 +41,26 @@ func (a *Analyzer) Analyze(contents map[file.Reference]string) ([]pkg.Package, e
 	for _, reference := range a.selectedFiles {
 		content, ok := contents[reference]
 		if !ok {
-			// TODO: this needs handling
-			panic(reference)
+			// TODO: test case
+			log.WithFields(map[string]interface{}{
+				"path":     reference.Path,
+				"id":       reference.ID(),
+				"analyzer": a.Name(),
+			}).Errorf("analyzer file content missing")
+
+			continue
 		}
 
 		entries, err := ParseEntries(strings.NewReader(content))
 		if err != nil {
-			// TODO: punt for now, we need to handle this
-			panic(err)
+			// TODO: test case
+			log.WithFields(map[string]interface{}{
+				"path":     reference.Path,
+				"id":       reference.ID(),
+				"analyzer": a.Name(),
+			}).Errorf("analyzer failed to parse entries: %w", err)
+
+			continue
 		}
 		for _, entry := range entries {
 			packages = append(packages, pkg.Package{
@@ -55,5 +72,6 @@ func (a *Analyzer) Analyze(contents map[file.Reference]string) ([]pkg.Package, e
 			})
 		}
 	}
+
 	return packages, nil
 }

imgbom/analyzer/dpkg/parser_test.go

@@ -54,7 +54,7 @@ func TestSinglePackage(t *testing.T) {
 			defer func() {
 				err := file.Close()
 				if err != nil {
-					panic(err)
+					t.Fatal("closing file failed:", err)
 				}
 			}()
 
@@ -123,7 +123,7 @@ func TestMultiplePackages(t *testing.T) {
 			defer func() {
 				err := file.Close()
 				if err != nil {
-					panic(err)
+					t.Fatal("closing file failed:", err)
 				}
 			}()