oss/syft
2
0
Fork 0
mirror of https://github.com/anchore/syft.git synced 2025-11-17 16:33:21 +01:00
Code Issues Packages Projects Releases Wiki Activity

add unit tests for distro identification based on "like" field

Browse Source 
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
This commit is contained in:
Alex Goodman 2021-08-12 14:09:22 -04:00
parent c833472b6e
commit 32a54b94be
No known key found for this signature in database
GPG Key ID: 5CB45AE22BAB7EA7
5 changed files with 25 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
syft/distro/identify.go
View File

@ -97,8 +97,7 @@ func assemble(name, version, like string) *Distro {
// If it's an unknown distro, try mapping the ID_LIKE // If it's an unknown distro, try mapping the ID_LIKE
if !ok && len(like) != 0 { if !ok && len(like) != 0 {
name = like distroType, ok = IDMapping[like]
distroType, ok = IDMapping[name]
} }
if ok { if ok {

17
syft/distro/identify_test.go
View File

@ -7,9 +7,8 @@ import (
"testing" "testing"
"github.com/anchore/syft/internal" "github.com/anchore/syft/internal"
"github.com/stretchr/testify/assert"
"github.com/anchore/syft/syft/source" "github.com/anchore/syft/syft/source"
"github.com/stretchr/testify/assert"
) )
func TestIdentifyDistro(t *testing.T) { func TestIdentifyDistro(t *testing.T) {
@ -85,6 +84,20 @@ func TestIdentifyDistro(t *testing.T) {
fixture: "test-fixtures/os/arch", fixture: "test-fixtures/os/arch",
Type: ArchLinux, Type: ArchLinux,
}, },
{
fixture: "test-fixtures/partial-fields/missing-id",
Type: Debian,
Version: "8.0.0",
},
{
fixture: "test-fixtures/partial-fields/unknown-id",
Type: Debian,
Version: "8.0.0",
},
{
fixture: "test-fixtures/partial-fields/missing-version",
Type: UnknownDistroType,
},
} }
observedDistros := internal.NewStringSet() observedDistros := internal.NewStringSet()

3
syft/distro/test-fixtures/partial-fields/missing-id/usr/lib/os-release Normal file
View File

@ -0,0 +1,3 @@
NAME="Debian GNU/Linux"
VERSION_ID="8"
ID_LIKE=debian

2
syft/distro/test-fixtures/partial-fields/missing-version/usr/lib/os-release Normal file
View File

@ -0,0 +1,2 @@
NAME="Debian GNU/Linux"
ID_LIKE=debian

4
syft/distro/test-fixtures/partial-fields/unknown-id/usr/lib/os-release Normal file
View File

@ -0,0 +1,4 @@
NAME="Debian GNU/Linux"
VERSION_ID="8"
ID=my-awesome-distro
ID_LIKE=debian