fix(java): improve lz4 detection (#4642)

Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@surgut.co.uk>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Co-authored-by: Keith Zantow <kzantow@gmail.com>

syft/pkg/cataloger/internal/cpegenerate/java.go

@@ -302,7 +302,11 @@ func GetManifestFieldGroupIDs(manifest *pkg.JavaManifest, fields []string) (grou
 }
 
 func cleanGroupID(groupID string) string {
-	return strings.TrimSpace(strings.Split(removeOSCIDirectives(groupID), "#")[0])
+	groupID = strings.TrimSpace(strings.Split(removeOSCIDirectives(groupID), "#")[0])
+	if replacement, ok := GroupIDCorrections[groupID]; ok {
+		return replacement
+	}
+	return groupID
 }
 
 func removeOSCIDirectives(groupID string) string {

syft/pkg/cataloger/internal/cpegenerate/java_groupid_map.go

@@ -1,5 +1,9 @@
 package cpegenerate
 
+var GroupIDCorrections = map[string]string{
+	"org.lz4.java": "org.lz4",
+}
+
 var DefaultArtifactIDToGroupID = map[string]string{
 	"ant":                                         "org.apache.ant",
 	"ant-antlr":                                   "org.apache.ant",

syft/pkg/cataloger/internal/cpegenerate/java_test.go

@@ -183,6 +183,22 @@ func Test_groupIDsFromJavaPackage(t *testing.T) {
 			},
 			expects: []string{"io.jenkins-ci.plugin.thing"},
 		},
+		{
+			name: "groupId correction properly applied",
+			pkg: pkg.Package{
+				Metadata: pkg.JavaArchive{
+					Manifest: &pkg.JavaManifest{
+						Main: pkg.KeyValues{
+							{
+								Key:   "Automatic-Module-Name",
+								Value: "org.lz4.java",
+							},
+						},
+					},
+				},
+			},
+			expects: []string{"org.lz4"},
+		},
 		{
 			name: "from main Extension-Name field",
 			pkg: pkg.Package{