From 3e8afc5274179d7e83a5f8d914a4ed5bbee7554a Mon Sep 17 00:00:00 2001 From: Christopher Angelo Phillips <32073428+spiffcs@users.noreply.github.com> Date: Tue, 21 Sep 2021 10:34:10 -0400 Subject: [PATCH] update log file permissions to 0644 (#511) Signed-off-by: Christopher Angelo Phillips --- internal/logger/logrus.go | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/internal/logger/logrus.go b/internal/logger/logrus.go index 96fad888c..0aea00c3e 100644 --- a/internal/logger/logrus.go +++ b/internal/logger/logrus.go @@ -3,6 +3,7 @@ package logger import ( "fmt" "io" + "io/fs" "io/ioutil" "os" @@ -10,6 +11,8 @@ import ( prefixed "github.com/x-cray/logrus-prefixed-formatter" ) +const defaultLogFilePermissions fs.FileMode = 0644 + // LogrusConfig contains all configurable values for the Logrus logger type LogrusConfig struct { EnableConsole bool @@ -38,7 +41,7 @@ func NewLogrusLogger(cfg LogrusConfig) *LogrusLogger { var output io.Writer switch { case cfg.EnableConsole && cfg.EnableFile: - logFile, err := os.OpenFile(cfg.FileLocation, os.O_WRONLY|os.O_CREATE, 0755) + logFile, err := os.OpenFile(cfg.FileLocation, os.O_WRONLY|os.O_CREATE, defaultLogFilePermissions) if err != nil { panic(fmt.Errorf("unable to setup log file: %w", err)) } @@ -46,7 +49,7 @@ func NewLogrusLogger(cfg LogrusConfig) *LogrusLogger { case cfg.EnableConsole: output = os.Stderr case cfg.EnableFile: - logFile, err := os.OpenFile(cfg.FileLocation, os.O_WRONLY|os.O_CREATE, 0755) + logFile, err := os.OpenFile(cfg.FileLocation, os.O_WRONLY|os.O_CREATE, defaultLogFilePermissions) if err != nil { panic(fmt.Errorf("unable to setup log file: %w", err)) }