Deduplicate digests from user configuration (#2522)

* deduplicate digests from user configuration

Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>

* backout pointer reciever change on imageSource

Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>

---------

Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>

cmd/syft/cli/options/file.go

@@ -2,6 +2,9 @@ package options
 
 import (
 	"fmt"
+	"sort"
+
+	"github.com/scylladb/go-set/strset"
 
 	intFile "github.com/anchore/syft/internal/file"
 	"github.com/anchore/syft/syft/file"
@@ -35,6 +38,10 @@ func defaultFileConfig() fileConfig {
 }
 
 func (c *fileConfig) PostLoad() error {
+	digests := strset.New(c.Metadata.Digests...).List()
+	sort.Strings(digests)
+	c.Metadata.Digests = digests
+
 	switch c.Metadata.Selection {
 	case file.NoFilesSelection, file.FilesOwnedByPackageSelection, file.AllFilesSelection:
 		return nil

cmd/syft/cli/options/file_test.go

@@ -0,0 +1,56 @@
+package options
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+
+	"github.com/anchore/syft/syft/file"
+)
+
+func Test_fileConfig_PostLoad(t *testing.T) {
+	tests := []struct {
+		name    string
+		cfg     fileConfig
+		assert  func(t *testing.T, cfg fileConfig)
+		wantErr assert.ErrorAssertionFunc
+	}{
+		{
+			name: "deduplicate digests",
+			cfg: fileConfig{
+				Metadata: fileMetadata{
+					Selection: file.NoFilesSelection,
+					Digests:   []string{"sha1", "sha1"},
+				},
+			},
+			assert: func(t *testing.T, cfg fileConfig) {
+				assert.Equal(t, []string{"sha1"}, cfg.Metadata.Digests)
+			},
+		},
+		{
+			name: "error on invalid selection",
+			cfg: fileConfig{
+				Metadata: fileMetadata{
+					Selection: file.Selection("invalid"),
+				},
+			},
+			wantErr: assert.Error,
+		},
+		{
+			name:    "error on empty selection",
+			cfg:     fileConfig{},
+			wantErr: assert.Error,
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			if tt.wantErr == nil {
+				tt.wantErr = assert.NoError
+			}
+			tt.wantErr(t, tt.cfg.PostLoad())
+			if tt.assert != nil {
+				tt.assert(t, tt.cfg)
+			}
+		})
+	}
+}

cmd/syft/cli/options/source.go

@@ -2,6 +2,7 @@ package options
 
 import (
 	"fmt"
+	"sort"
 	"strings"
 
 	"github.com/scylladb/go-set/strset"
@@ -34,6 +35,13 @@ func defaultSourceConfig() sourceConfig {
 	}
 }
 
+func (c *fileSource) PostLoad() error {
+	digests := strset.New(c.Digests...).List()
+	sort.Strings(digests)
+	c.Digests = digests
+	return nil
+}
+
 func (c imageSource) PostLoad() error {
 	return checkDefaultSourceValues(c.DefaultPullSource)
 }

cmd/syft/cli/options/source_test.go

@@ -0,0 +1,37 @@
+package options
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func Test_fileSource_PostLoad(t *testing.T) {
+	tests := []struct {
+		name    string
+		cfg     fileSource
+		assert  func(t *testing.T, cfg fileSource)
+		wantErr assert.ErrorAssertionFunc
+	}{
+		{
+			name: "deduplicate digests",
+			cfg: fileSource{
+				Digests: []string{"sha1", "sha1"},
+			},
+			assert: func(t *testing.T, cfg fileSource) {
+				assert.Equal(t, []string{"sha1"}, cfg.Digests)
+			},
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			if tt.wantErr == nil {
+				tt.wantErr = assert.NoError
+			}
+			tt.wantErr(t, tt.cfg.PostLoad())
+			if tt.assert != nil {
+				tt.assert(t, tt.cfg)
+			}
+		})
+	}
+}