From 42c78480167ee04f23ebd6592d97d8233e95bf70 Mon Sep 17 00:00:00 2001
From: Alex Goodman <wagoodman@users.noreply.github.com>
Date: Tue, 11 Nov 2025 13:39:03 -0500
Subject: [PATCH] troubleshoot artifact upload

Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
---
 .github/workflows/validations.yaml | 96 +++++++++++++++++++-----------
 1 file changed, 62 insertions(+), 34 deletions(-)

diff --git a/.github/workflows/validations.yaml b/.github/workflows/validations.yaml
index fd7d0cee0..5b5904cbf 100644
--- a/.github/workflows/validations.yaml
+++ b/.github/workflows/validations.yaml
@@ -88,41 +88,69 @@ jobs:
         run: make snapshot-smoke-test
 
       # upload each platform artifact individually so downstream jobs can download only what they need
-      - run: npm install @actions/artifact@2.2.2
-
-      - name: Upload individual platform artifacts
-        uses: actions/github-script@v8
-        env:
-          ACTIONS_ARTIFACT_UPLOAD_CONCURRENCY: 10
+      # using explicit upload steps instead of programmatic API for runs-on compatibility
+      - name: Upload Linux amd64 artifact
+        uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 #v4.6.0
         with:
-          script: |
-            const { readdirSync } = require('fs')
-            const { DefaultArtifactClient } = require('@actions/artifact')
-            const artifact = new DefaultArtifactClient()
-            const ls = d => readdirSync(d, { withFileTypes: true })
-            const baseDir = "./snapshot"
-            const dirs = ls(baseDir).filter(f => f.isDirectory()).map(f => f.name)
-            const uploads = []
-            for (const dir of dirs) {
-              // uploadArtifact returns Promise<{id, size}>
-              uploads.push(artifact.uploadArtifact(
-                // name of the archive:
-                `${dir}`,
-                // array of all files to include:
-                ls(`${baseDir}/${dir}`).map(f => `${baseDir}/${dir}/${f.name}`),
-                // base directory to trim from entries:
-                `${baseDir}/${dir}`,
-                { retentionDays: 30 }
-              ))
-            }
-            // wait for all uploads to finish
-            try {
-              const results = await Promise.all(uploads)
-              console.log(`Successfully uploaded ${results.length} platform artifacts`)
-            } catch (error) {
-              console.error('Upload failed:', error)
-              throw error
-            }
+          name: linux-build_linux_amd64_v1
+          path: snapshot/linux-build_linux_amd64_v1
+          retention-days: 30
+
+      - name: Upload Linux arm64 artifact
+        uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 #v4.6.0
+        with:
+          name: linux-build_linux_arm64_v8.0
+          path: snapshot/linux-build_linux_arm64_v8.0
+          retention-days: 30
+
+      - name: Upload Linux ppc64le artifact
+        uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 #v4.6.0
+        with:
+          name: linux-build_linux_ppc64le_power8
+          path: snapshot/linux-build_linux_ppc64le_power8
+          retention-days: 30
+
+      - name: Upload Linux s390x artifact
+        uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 #v4.6.0
+        with:
+          name: linux-build_linux_s390x
+          path: snapshot/linux-build_linux_s390x
+          retention-days: 30
+
+      - name: Upload macOS Intel artifact
+        uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 #v4.6.0
+        with:
+          name: darwin-build_darwin_amd64_v1
+          path: snapshot/darwin-build_darwin_amd64_v1
+          retention-days: 30
+
+      - name: Upload macOS Apple Silicon artifact
+        uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 #v4.6.0
+        with:
+          name: darwin-build_darwin_arm64_v8.0
+          path: snapshot/darwin-build_darwin_arm64_v8.0
+          retention-days: 30
+
+      - name: Upload Windows amd64 artifact
+        uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 #v4.6.0
+        with:
+          name: windows-build_windows_amd64_v1
+          path: snapshot/windows-build_windows_amd64_v1
+          retention-days: 30
+
+      - name: Upload Windows arm64 artifact
+        uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 #v4.6.0
+        with:
+          name: windows-build_windows_arm64_v8.0
+          path: snapshot/windows-build_windows_arm64_v8.0
+          retention-days: 30
+
+      - name: Upload Homebrew artifact
+        uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 #v4.6.0
+        with:
+          name: homebrew
+          path: snapshot/homebrew
+          retention-days: 30
 
   Acceptance-Linux:
     # Note: changing this job name requires making the same update in the .github/workflows/release.yaml pipeline