Remove the power-user command and related catalogers (#2306)

* remove the power-user command

Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>

* remove secrets + classifier catalogers

Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>

* bump json schema

Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>

* regenerate json schema

Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>

---------

Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>

cmd/syft/cli/ui/handle_secrets_cataloger.go

@@ -1,57 +0,0 @@
-package ui
-
-import (
-	"fmt"
-
-	tea "github.com/charmbracelet/bubbletea"
-	"github.com/wagoodman/go-partybus"
-	"github.com/wagoodman/go-progress"
-
-	"github.com/anchore/bubbly/bubbles/taskprogress"
-	"github.com/anchore/syft/internal/log"
-	syftEventParsers "github.com/anchore/syft/syft/event/parsers"
-	"github.com/anchore/syft/syft/file/cataloger/secrets"
-)
-
-var _ progress.StagedProgressable = (*secretsCatalogerProgressAdapter)(nil)
-
-// Deprecated: will be removed in syft 1.0
-type secretsCatalogerProgressAdapter struct {
-	*secrets.Monitor
-}
-
-// Deprecated: will be removed in syft 1.0
-func newSecretsCatalogerProgressAdapter(monitor *secrets.Monitor) secretsCatalogerProgressAdapter {
-	return secretsCatalogerProgressAdapter{
-		Monitor: monitor,
-	}
-}
-
-func (s secretsCatalogerProgressAdapter) Stage() string {
-	return fmt.Sprintf("%d secrets", s.Monitor.SecretsDiscovered.Current())
-}
-
-// Deprecated: will be removed in syft 1.0
-func (m *Handler) handleSecretsCatalogerStarted(e partybus.Event) []tea.Model {
-	mon, err := syftEventParsers.ParseSecretsCatalogingStarted(e)
-	if err != nil {
-		log.WithFields("error", err).Warn("unable to parse event")
-		return nil
-	}
-
-	tsk := m.newTaskProgress(
-		taskprogress.Title{
-			Default: "Catalog secrets",
-			Running: "Cataloging secrets",
-			Success: "Cataloged secrets",
-		},
-
-		taskprogress.WithStagedProgressable(
-			newSecretsCatalogerProgressAdapter(mon),
-		),
-	)
-
-	tsk.HideStageOnSuccess = false
-
-	return []tea.Model{tsk}
-}

cmd/syft/cli/ui/handle_secrets_cataloger_test.go

@@ -1,96 +0,0 @@
-package ui
-
-import (
-	"testing"
-	"time"
-
-	tea "github.com/charmbracelet/bubbletea"
-	"github.com/gkampitakis/go-snaps/snaps"
-	"github.com/stretchr/testify/require"
-	"github.com/wagoodman/go-partybus"
-	"github.com/wagoodman/go-progress"
-
-	"github.com/anchore/bubbly/bubbles/taskprogress"
-	syftEvent "github.com/anchore/syft/syft/event"
-	"github.com/anchore/syft/syft/file/cataloger/secrets"
-)
-
-func TestHandler_handleSecretsCatalogerStarted(t *testing.T) {
-
-	tests := []struct {
-		name       string
-		eventFn    func(*testing.T) partybus.Event
-		iterations int
-	}{
-		{
-			name: "cataloging in progress",
-			eventFn: func(t *testing.T) partybus.Event {
-				stage := &progress.Stage{
-					Current: "current",
-				}
-				secretsDiscovered := progress.NewManual(-1)
-				secretsDiscovered.Set(64)
-				prog := progress.NewManual(72)
-				prog.Set(50)
-
-				return partybus.Event{
-					Type:   syftEvent.SecretsCatalogerStarted,
-					Source: secretsDiscovered,
-					Value: secrets.Monitor{
-						Stager:            progress.Stager(stage),
-						SecretsDiscovered: secretsDiscovered,
-						Progressable:      prog,
-					},
-				}
-			},
-		},
-		{
-			name: "cataloging complete",
-			eventFn: func(t *testing.T) partybus.Event {
-				stage := &progress.Stage{
-					Current: "current",
-				}
-				secretsDiscovered := progress.NewManual(-1)
-				secretsDiscovered.Set(64)
-				prog := progress.NewManual(72)
-				prog.Set(72)
-				prog.SetCompleted()
-
-				return partybus.Event{
-					Type:   syftEvent.SecretsCatalogerStarted,
-					Source: secretsDiscovered,
-					Value: secrets.Monitor{
-						Stager:            progress.Stager(stage),
-						SecretsDiscovered: secretsDiscovered,
-						Progressable:      prog,
-					},
-				}
-			},
-		},
-	}
-	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
-			event := tt.eventFn(t)
-			handler := New(DefaultHandlerConfig())
-			handler.WindowSize = tea.WindowSizeMsg{
-				Width:  100,
-				Height: 80,
-			}
-
-			models := handler.Handle(event)
-			require.Len(t, models, 1)
-			model := models[0]
-
-			tsk, ok := model.(taskprogress.Model)
-			require.True(t, ok)
-
-			got := runModel(t, tsk, tt.iterations, taskprogress.TickMsg{
-				Time:     time.Now(),
-				Sequence: tsk.Sequence(),
-				ID:       tsk.ID(),
-			})
-			t.Log(got)
-			snaps.MatchSnapshot(t, got)
-		})
-	}
-}

cmd/syft/cli/ui/handler.go

@@ -58,9 +58,6 @@ func New(cfg HandlerConfig) *Handler {
 		syftEvent.FileIndexingStarted:          h.handleFileIndexingStarted,
 		syftEvent.AttestationStarted:           h.handleAttestationStarted,
 		syftEvent.CatalogerTaskStarted:         h.handleCatalogerTaskStarted,
-
-		// deprecated
-		syftEvent.SecretsCatalogerStarted: h.handleSecretsCatalogerStarted,
 	})
 
 	return h