add tests around MatchNamedCaptureGroups + rename

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>

syft/pkg/cataloger/deb/parse_copyright.go

@@ -21,7 +21,7 @@ func parseLicensesFromCopyright(reader io.Reader) []string {
 	for scanner.Scan() {
 		line := scanner.Text()
 
-		matchesByGroup := internal.MatchCaptureGroups(licensePattern, line)
+		matchesByGroup := internal.MatchNamedCaptureGroups(licensePattern, line)
 		if len(matchesByGroup) > 0 {
 			candidate, ok := matchesByGroup["license"]
 			if !ok {

syft/pkg/cataloger/deb/parse_dpkg_status.go

@@ -145,7 +145,7 @@ func extractAllFields(reader *bufio.Reader) (map[string]interface{}, error) {
 // of the "<name>" form, then return name and nil
 func extractSourceVersion(source string) (string, string) {
 	// special handling for the Source field since it has formatted data
-	match := internal.MatchCaptureGroups(sourceRegexp, source)
+	match := internal.MatchNamedCaptureGroups(sourceRegexp, source)
 	return match["name"], match["version"]
 }
 

syft/pkg/cataloger/javascript/parse_package_json.go

@@ -63,7 +63,7 @@ func (a *Author) UnmarshalJSON(b []byte) error {
 		}
 	} else {
 		// parse out "name <email> (url)" into an Author struct
-		fields = internal.MatchCaptureGroups(authorPattern, authorStr)
+		fields = internal.MatchNamedCaptureGroups(authorPattern, authorStr)
 	}
 
 	// translate the map into a structure

syft/pkg/cataloger/ruby/parse_gemspec.go

@@ -77,7 +77,7 @@ func parseGemSpecEntries(_ string, reader io.Reader) ([]pkg.Package, error) {
 		}
 
 		for field, pattern := range patterns {
-			matchMap := internal.MatchCaptureGroups(pattern, sanitizedLine)
+			matchMap := internal.MatchNamedCaptureGroups(pattern, sanitizedLine)
 			if value := matchMap[field]; value != "" {
 				if postProcessor := postProcessors[field]; postProcessor != nil {
 					fields[field] = postProcessor(value)