From 628c2e44a5ce039a1a12b8f9748e8a3b1ca8d251 Mon Sep 17 00:00:00 2001 From: Alex Goodman Date: Wed, 10 Nov 2021 13:34:41 -0500 Subject: [PATCH] add test reminders to put new relationships under test Signed-off-by: Alex Goodman --- syft/pkg/cataloger/apkdb/parse_apk_db_test.go | 1 + syft/pkg/cataloger/golang/parse_go_mod_test.go | 1 + syft/pkg/cataloger/javascript/parse_package_json_test.go | 1 + syft/pkg/cataloger/javascript/parse_package_lock_test.go | 1 + syft/pkg/cataloger/javascript/parse_yarn_lock_test.go | 1 + syft/pkg/cataloger/python/parse_pipfile_lock_test.go | 1 + syft/pkg/cataloger/python/parse_poetry_lock_test.go | 1 + syft/pkg/cataloger/python/parse_requirements_test.go | 1 + syft/pkg/cataloger/ruby/parse_gemfile_lock_test.go | 1 + syft/pkg/cataloger/ruby/parse_gemspec_test.go | 1 + syft/pkg/cataloger/rust/parse_cargo_lock_test.go | 1 + 11 files changed, 11 insertions(+) diff --git a/syft/pkg/cataloger/apkdb/parse_apk_db_test.go b/syft/pkg/cataloger/apkdb/parse_apk_db_test.go index cdd0c1cdc..13926274e 100644 --- a/syft/pkg/cataloger/apkdb/parse_apk_db_test.go +++ b/syft/pkg/cataloger/apkdb/parse_apk_db_test.go @@ -775,6 +775,7 @@ func TestMultiplePackages(t *testing.T) { } }() + // TODO: no relationships are under test yet pkgs, _, err := parseApkDB(file.Name(), file) if err != nil { t.Fatal("Unable to read file contents: ", err) diff --git a/syft/pkg/cataloger/golang/parse_go_mod_test.go b/syft/pkg/cataloger/golang/parse_go_mod_test.go index 9be70d851..54d5b5465 100644 --- a/syft/pkg/cataloger/golang/parse_go_mod_test.go +++ b/syft/pkg/cataloger/golang/parse_go_mod_test.go @@ -70,6 +70,7 @@ func TestParseGoMod(t *testing.T) { t.Fatalf(err.Error()) } + // TODO: no relationships are under test yet actual, _, err := parseGoMod(test.fixture, f) if err != nil { t.Fatalf(err.Error()) diff --git a/syft/pkg/cataloger/javascript/parse_package_json_test.go b/syft/pkg/cataloger/javascript/parse_package_json_test.go index 2608ac358..cce594cb1 100644 --- a/syft/pkg/cataloger/javascript/parse_package_json_test.go +++ b/syft/pkg/cataloger/javascript/parse_package_json_test.go @@ -150,6 +150,7 @@ func TestParsePackageJSON_Partial(t *testing.T) { // see https://github.com/anch t.Fatalf("failed to open fixture: %+v", err) } + // TODO: no relationships are under test yet actual, _, err := parsePackageJSON("", fixture) if err != nil { t.Fatalf("failed to parse package-lock.json: %+v", err) diff --git a/syft/pkg/cataloger/javascript/parse_package_lock_test.go b/syft/pkg/cataloger/javascript/parse_package_lock_test.go index 07839b529..0f33aaa83 100644 --- a/syft/pkg/cataloger/javascript/parse_package_lock_test.go +++ b/syft/pkg/cataloger/javascript/parse_package_lock_test.go @@ -109,6 +109,7 @@ func TestParsePackageLock(t *testing.T) { t.Fatalf("failed to open fixture: %+v", err) } + // TODO: no relationships are under test yet actual, _, err := parsePackageLock(fixture.Name(), fixture) if err != nil { t.Fatalf("failed to parse package-lock.json: %+v", err) diff --git a/syft/pkg/cataloger/javascript/parse_yarn_lock_test.go b/syft/pkg/cataloger/javascript/parse_yarn_lock_test.go index 06901d06a..5ef0242d9 100644 --- a/syft/pkg/cataloger/javascript/parse_yarn_lock_test.go +++ b/syft/pkg/cataloger/javascript/parse_yarn_lock_test.go @@ -70,6 +70,7 @@ func TestParseYarnLock(t *testing.T) { t.Fatalf("failed to open fixture: %+v", err) } + // TODO: no relationships are under test yet actual, _, err := parseYarnLock(fixture.Name(), fixture) if err != nil { t.Fatalf("failed to parse yarn.lock: %+v", err) diff --git a/syft/pkg/cataloger/python/parse_pipfile_lock_test.go b/syft/pkg/cataloger/python/parse_pipfile_lock_test.go index b1fab39af..2e4fedc9d 100644 --- a/syft/pkg/cataloger/python/parse_pipfile_lock_test.go +++ b/syft/pkg/cataloger/python/parse_pipfile_lock_test.go @@ -39,6 +39,7 @@ func TestParsePipFileLock(t *testing.T) { t.Fatalf("failed to open fixture: %+v", err) } + // TODO: no relationships are under test yet actual, _, err := parsePipfileLock(fixture.Name(), fixture) if err != nil { t.Fatalf("failed to parse requirements: %+v", err) diff --git a/syft/pkg/cataloger/python/parse_poetry_lock_test.go b/syft/pkg/cataloger/python/parse_poetry_lock_test.go index 849401634..5f30c213f 100644 --- a/syft/pkg/cataloger/python/parse_poetry_lock_test.go +++ b/syft/pkg/cataloger/python/parse_poetry_lock_test.go @@ -45,6 +45,7 @@ func TestParsePoetryLock(t *testing.T) { t.Fatalf("failed to open fixture: %+v", err) } + // TODO: no relationships are under test yet actual, _, err := parsePoetryLock(fixture.Name(), fixture) if err != nil { t.Error(err) diff --git a/syft/pkg/cataloger/python/parse_requirements_test.go b/syft/pkg/cataloger/python/parse_requirements_test.go index dee6d1bf7..f84913ac0 100644 --- a/syft/pkg/cataloger/python/parse_requirements_test.go +++ b/syft/pkg/cataloger/python/parse_requirements_test.go @@ -50,6 +50,7 @@ func TestParseRequirementsTxt(t *testing.T) { t.Fatalf("failed to open fixture: %+v", err) } + // TODO: no relationships are under test yet actual, _, err := parseRequirementsTxt(fixture.Name(), fixture) if err != nil { t.Fatalf("failed to parse requirements: %+v", err) diff --git a/syft/pkg/cataloger/ruby/parse_gemfile_lock_test.go b/syft/pkg/cataloger/ruby/parse_gemfile_lock_test.go index dfd08205c..56cb5f277 100644 --- a/syft/pkg/cataloger/ruby/parse_gemfile_lock_test.go +++ b/syft/pkg/cataloger/ruby/parse_gemfile_lock_test.go @@ -68,6 +68,7 @@ func TestParseGemfileLockEntries(t *testing.T) { t.Fatalf("failed to open fixture: %+v", err) } + // TODO: no relationships are under test yet actual, _, err := parseGemFileLockEntries(fixture.Name(), fixture) if err != nil { t.Fatalf("failed to parse gemfile lock: %+v", err) diff --git a/syft/pkg/cataloger/ruby/parse_gemspec_test.go b/syft/pkg/cataloger/ruby/parse_gemspec_test.go index cb3b4ce5c..d98cc4370 100644 --- a/syft/pkg/cataloger/ruby/parse_gemspec_test.go +++ b/syft/pkg/cataloger/ruby/parse_gemspec_test.go @@ -31,6 +31,7 @@ func TestParseGemspec(t *testing.T) { t.Fatalf("failed to open fixture: %+v", err) } + // TODO: no relationships are under test yet actual, _, err := parseGemSpecEntries(fixture.Name(), fixture) if err != nil { t.Fatalf("failed to parse gemspec: %+v", err) diff --git a/syft/pkg/cataloger/rust/parse_cargo_lock_test.go b/syft/pkg/cataloger/rust/parse_cargo_lock_test.go index 946b8887b..c5c88ffa4 100644 --- a/syft/pkg/cataloger/rust/parse_cargo_lock_test.go +++ b/syft/pkg/cataloger/rust/parse_cargo_lock_test.go @@ -177,6 +177,7 @@ func TestParseCargoLock(t *testing.T) { t.Fatalf("failed to open fixture: %+v", err) } + // TODO: no relationships are under test yet actual, _, err := parseCargoLock(fixture.Name(), fixture) if err != nil { t.Error(err)