From 7ca1f22395c788a544288ec98b55527c364be0d9 Mon Sep 17 00:00:00 2001 From: Pujitha Paladugu Date: Fri, 21 Aug 2026 11:53:45 -0700 Subject: [PATCH] fix(dotnet): correct inverted dependency-of relationship direction in packages.lock.json parser (#5143) Fixes #5125 Signed-off-by: Pujitha Paladugu <10557236+pujitha24@users.noreply.github.com> Co-authored-by: Pujitha Paladugu <10557236+pujitha24@users.noreply.github.com> --- .../cataloger/dotnet/parse_packages_lock.go | 4 +-- .../dotnet/parse_packages_lock_test.go | 28 +++++++++---------- 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/syft/pkg/cataloger/dotnet/parse_packages_lock.go b/syft/pkg/cataloger/dotnet/parse_packages_lock.go index 99535d9da..3348d5a0f 100644 --- a/syft/pkg/cataloger/dotnet/parse_packages_lock.go +++ b/syft/pkg/cataloger/dotnet/parse_packages_lock.go @@ -101,8 +101,8 @@ func parseDotnetPackagesLock(_ context.Context, _ file.Resolver, _ *generic.Envi } rel := artifact.Relationship{ - From: parentPkg, - To: childPkg, + From: childPkg, + To: parentPkg, Type: artifact.DependencyOfRelationship, } relationships = append(relationships, rel) diff --git a/syft/pkg/cataloger/dotnet/parse_packages_lock_test.go b/syft/pkg/cataloger/dotnet/parse_packages_lock_test.go index 4d8a2c2d7..24ce33454 100644 --- a/syft/pkg/cataloger/dotnet/parse_packages_lock_test.go +++ b/syft/pkg/cataloger/dotnet/parse_packages_lock_test.go @@ -169,28 +169,28 @@ func TestParseDotnetPackagesLock(t *testing.T) { expectedRelationships := []artifact.Relationship{ { - From: autoMapperPkg, + From: extensionOptionsPkg, + To: autoMapperPkg, + Type: artifact.DependencyOfRelationship, + }, + { + From: dependencyInjectionAbstractionsPkg, To: extensionOptionsPkg, Type: artifact.DependencyOfRelationship, }, - { - From: extensionOptionsPkg, - To: dependencyInjectionAbstractionsPkg, - Type: artifact.DependencyOfRelationship, - }, - { - From: extensionOptionsPkg, - To: extensionPrimitivesPkg, - Type: artifact.DependencyOfRelationship, - }, { From: extensionPrimitivesPkg, - To: compilerServicesUnsafePkg, + To: extensionOptionsPkg, Type: artifact.DependencyOfRelationship, }, { - From: microsoftLoggingPkg, - To: extensionOptionsPkg, + From: compilerServicesUnsafePkg, + To: extensionPrimitivesPkg, + Type: artifact.DependencyOfRelationship, + }, + { + From: extensionOptionsPkg, + To: microsoftLoggingPkg, Type: artifact.DependencyOfRelationship, }, }