From 8d36b212370860c5cc152deb3d710267fcbed857 Mon Sep 17 00:00:00 2001 From: Justin Chadwell Date: Tue, 3 Jan 2023 14:54:08 +0000 Subject: [PATCH] fix: additional excessive go binary warnings (#1432) The original fix b125ea83baa30dc981e82f4ddd384602f778f090 didn't catch all the excessive warnings, it seems like getArches can also be called on binaries that aren't neccessarily go binaries, so the messages from this should also be Trace instead of Warn. Signed-off-by: Justin Chadwell --- syft/pkg/cataloger/golang/parse_go_binary.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/syft/pkg/cataloger/golang/parse_go_binary.go b/syft/pkg/cataloger/golang/parse_go_binary.go index 31f6ca2cd..80008bd3a 100644 --- a/syft/pkg/cataloger/golang/parse_go_binary.go +++ b/syft/pkg/cataloger/golang/parse_go_binary.go @@ -85,12 +85,12 @@ func makeGoMainPackage(mod *debug.BuildInfo, arch string, location source.Locati // 2) reading file headers from binaries compiled by < go1.18 func getArchs(readers []io.ReaderAt, builds []*debug.BuildInfo) []string { if len(readers) != len(builds) { - log.Warnf("golang cataloger: bin parsing: number of builds and readers doesn't match") + log.Trace("golang cataloger: bin parsing: number of builds and readers doesn't match") return nil } if len(readers) == 0 || len(builds) == 0 { - log.Warnf("golang cataloger: bin parsing: %d readers and %d build info items", len(readers), len(builds)) + log.Tracef("golang cataloger: bin parsing: %d readers and %d build info items", len(readers), len(builds)) return nil } @@ -107,7 +107,7 @@ func getArchs(readers []io.ReaderAt, builds []*debug.BuildInfo) []string { for i, r := range readers { a, err := getGOARCHFromBin(r) if err != nil { - log.Warnf("golang cataloger: bin parsing: getting arch from binary: %v", err) + log.Tracef("golang cataloger: bin parsing: getting arch from binary: %v", err) continue }