oss/syft
2
0
Fork 0
mirror of https://github.com/anchore/syft.git synced 2026-02-13 11:06:43 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: update config struct to not decode password/key (#1538)

Browse Source 
* fix: update config struct to not decode password/key
* test: update tests to confirm no secrets in output

Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
---------

Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
This commit is contained in:
Christopher Angelo Phillips 2023-02-03 13:06:14 -05:00 committed by GitHub
parent b6a496f18c
commit 9995950c70
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 17 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
internal/config/attest.go
View File

@ -3,8 +3,9 @@ package config
import "github.com/spf13/viper" import "github.com/spf13/viper"
type attest struct { type attest struct {
Key string `yaml:"key" json:"key" mapstructure:"key"` // IMPORTANT: do not show the attestation key/password in any YAML/JSON output (sensitive information)
Password string `yaml:"password" json:"password" mapstructure:"password"` Key string `yaml:"-" json:"-" mapstructure:"key"`
Password string `yaml:"-" json:"-" mapstructure:"password"`
} }
func (cfg attest) loadDefaultValues(v *viper.Viper) { func (cfg attest) loadDefaultValues(v *viper.Viper) {

14
test/cli/packages_cmd_test.go
View File

@ -229,6 +229,20 @@ func TestPackagesCmdFlags(t *testing.T) {
assertSuccessfulReturnCode, assertSuccessfulReturnCode,
}, },
}, },
{
name: "password and key not in config output",
args: []string{"packages", "-vvv", "-o", "json", coverageImage},
env: map[string]string{
"SYFT_ATTEST_PASSWORD": "secret_password",
"SYFT_ATTEST_KEY": "secret_key_path",
},
assertions: []traitAssertion{
assertNotInOutput("secret_password"),
assertNotInOutput("secret_key_path"),
assertPackageCount(34),
assertSuccessfulReturnCode,
},
},
} }
for _, test := range tests { for _, test := range tests {