From a70e89b2ed29b8ce9afa58a64c331f2ccc57c2d7 Mon Sep 17 00:00:00 2001 From: Alex Goodman Date: Tue, 11 Nov 2025 15:34:56 -0500 Subject: [PATCH] use action to get artifacts working Signed-off-by: Alex Goodman --- .github/workflows/validations.yaml | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/.github/workflows/validations.yaml b/.github/workflows/validations.yaml index 053c360c9..1cdf1791c 100644 --- a/.github/workflows/validations.yaml +++ b/.github/workflows/validations.yaml @@ -70,10 +70,11 @@ jobs: Build-Snapshot-Artifacts: name: "Build snapshot artifacts" # Runner definition: workflows/.github/runs-on.yml - # note: we explicitly do not use the magic cache feature (https://runs-on.com/caching/magic-cache/) - # since it is not compatible with artifact uploads/downloads in the same workflow (https://runs-on.com/caching/magic-cache/#actionsupload-artifact-compatibility) - runs-on: runs-on=${{ github.run_id }}/runner=build/extras= + runs-on: runs-on=${{ github.run_id }}/runner=build steps: + # required for magic-cache from runs-on to function with artifact upload/download (see https://runs-on.com/caching/magic-cache/#actionsupload-artifact-compatibility) + - uses: runs-on/action@v2 + - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 #v5.0.0 with: persist-credentials: false @@ -167,8 +168,11 @@ jobs: name: "Acceptance tests (Linux)" needs: [Build-Snapshot-Artifacts] # Runner definition: workflows/.github/runs-on.yml - runs-on: runs-on=${{ github.run_id }}/runner=small/extras= + runs-on: runs-on=${{ github.run_id }}/runner=small steps: + # required for magic-cache from runs-on to function with artifact upload/download (see https://runs-on.com/caching/magic-cache/#actionsupload-artifact-compatibility) + - uses: runs-on/action@v2 + - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 #v5.0.0 with: persist-credentials: false @@ -208,6 +212,7 @@ jobs: # Note: changing this job name requires making the same update in the .github/workflows/release.yaml pipeline name: "Acceptance tests (Mac)" needs: [Build-Snapshot-Artifacts] + # note: macos runners aren't supported yet for runs-on managed runners. runs-on: macos-latest steps: - name: Install Cosign @@ -247,8 +252,11 @@ jobs: name: "CLI tests (Linux)" needs: [Build-Snapshot-Artifacts] # Runner definition: workflows/.github/runs-on.yml - runs-on: runs-on=${{ github.run_id }}/runner=small/extras= + runs-on: runs-on=${{ github.run_id }}/runner=small steps: + # required for magic-cache from runs-on to function with artifact upload/download (see https://runs-on.com/caching/magic-cache/#actionsupload-artifact-compatibility) + - uses: runs-on/action@v2 + - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 #v5.0.0 with: persist-credentials: false