oss/syft
2
0
Fork 0
mirror of https://github.com/anchore/syft.git synced 2025-11-17 16:33:21 +01:00
Code Issues Packages Projects Releases Wiki Activity

Remove and update TODOs (#194)

Browse Source 
* Remove and update TODOs

Signed-off-by: Dan Luhring <dan.luhring@anchore.com>

* Update TODO with link

Signed-off-by: Dan Luhring <dan.luhring@anchore.com>
This commit is contained in:
Dan Luhring 2020-09-29 11:53:19 -04:00 committed by GitHub
parent b5ce187ba7
commit b6dfdf16b6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
syft/cataloger/java/test-fixtures/java-builds/example-jenkins-plugin/src/main/resources/index.jelly
View File

@ -1,4 +1,3 @@
<?jelly escape-by-default='true'?> <?jelly escape-by-default='true'?>
<div> <div>
TODO
</div> </div>

2
syft/pkg/catalog.go
View File

@ -8,8 +8,6 @@ import (
"github.com/anchore/syft/internal/log" "github.com/anchore/syft/internal/log"
) )
// TODO: add reader methods (by type, id, fuzzy search, etc)
var nextPackageID int64 var nextPackageID int64
// Catalog represents a collection of Packages. // Catalog represents a collection of Packages.

2
syft/presenter/text/presenter_test.go
View File

@ -93,7 +93,7 @@ func TestTextImgPresenter(t *testing.T) {
}) })
// stub out all the digests so that they don't affect tests comparisons // stub out all the digests so that they don't affect tests comparisons
// TODO: update with go-testutils feature when issue #1 is resolved // TODO: update with stereoscope test utils feature when this issue is resolved: https://github.com/anchore/stereoscope/issues/43
for _, l := range img.Layers { for _, l := range img.Layers {
l.Metadata.Digest = "sha256:ad8ecdc058976c07e7e347cb89fa9ad86a294b5ceaae6d09713fb035f84115abf3c4a2388a4af3aa60f13b94f4c6846930bdf53" l.Metadata.Digest = "sha256:ad8ecdc058976c07e7e347cb89fa9ad86a294b5ceaae6d09713fb035f84115abf3c4a2388a4af3aa60f13b94f4c6846930bdf53"
} }

6
test/inline-compare/compare-all.sh
View File

@ -1,8 +1,8 @@
#!/usr/bin/env bash #!/usr/bin/env bash
set -eu set -eu
# TODO: add "alpine:3.12.0" back # TODO: Add "alpine:3.12.0" back in when we've figured out how to handle the apk version field w/ and w/o release information (see issue: https://github.com/anchore/syft/pull/195)
images=("debian:10.5" "centos:8.2.2004" ) images=("debian:10.5" "centos:8.2.2004")
# gather all image analyses # gather all image analyses
for img in "${images[@]}"; do for img in "${images[@]}"; do
@ -14,4 +14,4 @@ done
for img in "${images[@]}"; do for img in "${images[@]}"; do
echo "Comparing results for $img" echo "Comparing results for $img"
COMPARE_IMAGE=${img} make compare-image COMPARE_IMAGE=${img} make compare-image
done done