exclusions does not need to be variadic (#711)

This commit is contained in:
Keith Zantow
2021-12-21 10:13:15 -05:00
committed by GitHub
parent cc20a8f341
commit b7979dbc7d
6 changed files with 8 additions and 8 deletions
+1 -1
View File
@@ -35,7 +35,7 @@ type Source struct {
type sourceDetector func(string) (image.Source, string, error)
// New produces a Source based on userInput like dir: or image:tag
func New(userInput string, registryOptions *image.RegistryOptions, exclusions ...string) (*Source, func(), error) {
func New(userInput string, registryOptions *image.RegistryOptions, exclusions []string) (*Source, func(), error) {
fs := afero.NewOsFs()
parsedScheme, imageSource, location, err := detectScheme(fs, image.DetectSource, userInput)
if err != nil {
+2 -2
View File
@@ -420,7 +420,7 @@ func TestDirectoryExclusions(t *testing.T) {
registryOpts := &image.RegistryOptions{}
for _, test := range testCases {
t.Run(test.desc, func(t *testing.T) {
src, fn, err := New("dir:"+test.input, registryOpts, test.exclusions...)
src, fn, err := New("dir:"+test.input, registryOpts, test.exclusions)
defer fn()
if test.err {
@@ -512,7 +512,7 @@ func TestImageExclusions(t *testing.T) {
for _, test := range testCases {
t.Run(test.desc, func(t *testing.T) {
archiveLocation := imagetest.PrepareFixtureImage(t, "docker-archive", test.input)
src, fn, err := New(archiveLocation, registryOpts, test.exclusions...)
src, fn, err := New(archiveLocation, registryOpts, test.exclusions)
defer fn()
if err != nil {