oss/syft
2
0
Fork 0
mirror of https://github.com/anchore/syft.git synced 2025-11-17 16:33:21 +01:00
Code Issues Packages Projects Releases Wiki Activity

fill out new version notice (#2042)

Browse Source 
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
This commit is contained in:
Alex Goodman 2023-08-18 16:03:11 -04:00 committed by GitHub
parent 4762ba0943
commit cb0214ec1d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
cmd/syft/internal/ui/__snapshots__/post_ui_event_writer_test.snap
View File

@ -27,12 +27,7 @@ report 1!!>
<notification 2> <notification 2>
<notification 3> <notification 3>
A newer version of syft is available for download: v0.33.0 (installed version is [not provided])
<my app can be updated!!
...to this version>
--- ---

5
cmd/syft/internal/ui/post_ui_event_writer.go
View File

@ -10,6 +10,7 @@ import (
"github.com/wagoodman/go-partybus" "github.com/wagoodman/go-partybus"
"github.com/anchore/syft/internal/log" "github.com/anchore/syft/internal/log"
"github.com/anchore/syft/internal/version"
"github.com/anchore/syft/syft/event" "github.com/anchore/syft/syft/event"
"github.com/anchore/syft/syft/event/parsers" "github.com/anchore/syft/syft/event/parsers"
) )
@ -118,12 +119,14 @@ func writeAppUpdate(writer io.Writer, events ...partybus.Event) error {
style := lipgloss.NewStyle().Foreground(lipgloss.Color("13")).Italic(true) style := lipgloss.NewStyle().Foreground(lipgloss.Color("13")).Italic(true)
for _, e := range events { for _, e := range events {
notice, err := parsers.ParseCLIAppUpdateAvailable(e) newVersion, err := parsers.ParseCLIAppUpdateAvailable(e)
if err != nil { if err != nil {
log.WithFields("error", err).Warn("failed to parse app update notification") log.WithFields("error", err).Warn("failed to parse app update notification")
continue continue
} }
notice := fmt.Sprintf("A newer version of syft is available for download: %s (installed version is %s)", newVersion, version.FromBuild().Version)
if _, err := fmt.Fprintln(writer, style.Render(notice)); err != nil { if _, err := fmt.Fprintln(writer, style.Render(notice)); err != nil {
// don't let this be fatal // don't let this be fatal
log.WithFields("error", err).Warn("failed to write app update notification") log.WithFields("error", err).Warn("failed to write app update notification")

2
cmd/syft/internal/ui/post_ui_event_writer_test.go
View File

@ -35,7 +35,7 @@ func Test_postUIEventWriter_write(t *testing.T) {
}, },
{ {
Type: event.CLIAppUpdateAvailable, Type: event.CLIAppUpdateAvailable,
Value: "\n\n<my app can be updated!!\n...to this version>\n\n", Value: "v0.33.0",
}, },
{ {
Type: event.CLINotification, Type: event.CLINotification,