From e9e9fe6d9c73e46200ad47aba09bba4a9bb22f76 Mon Sep 17 00:00:00 2001 From: Alex Goodman Date: Sat, 20 Mar 2021 08:08:46 -0400 Subject: [PATCH] prefer warnings over errors when parsing java manifests and pom properties Signed-off-by: Alex Goodman --- syft/cataloger/java/archive_parser.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/syft/cataloger/java/archive_parser.go b/syft/cataloger/java/archive_parser.go index 7b103e9b8..05446ae08 100644 --- a/syft/cataloger/java/archive_parser.go +++ b/syft/cataloger/java/archive_parser.go @@ -142,7 +142,8 @@ func (j *archiveParser) discoverMainPackage() (*pkg.Package, error) { manifestContents := contents[manifestMatches[0]] manifest, err := parseJavaManifest(j.archivePath, strings.NewReader(manifestContents)) if err != nil { - return nil, fmt.Errorf("failed to parse java manifest (%s): %w", j.virtualPath, err) + log.Warnf("failed to parse java manifest (%s): %+v", j.virtualPath, err) + return nil, nil } return &pkg.Package{ @@ -175,7 +176,8 @@ func (j *archiveParser) discoverPkgsFromPomProperties(parentPkg *pkg.Package) ([ for propsPath, propsContents := range contents { propsObj, err := parsePomProperties(propsPath, strings.NewReader(propsContents)) if err != nil { - return nil, fmt.Errorf("failed to parse pom.properties (%s): %w", j.virtualPath, err) + log.Warnf("failed to parse pom.properties (%s): %+v", j.virtualPath, err) + continue } if propsObj == nil {