fix: ensure java image build failures stop the build (#4531)

---------
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>

syft/pkg/cataloger/golang/test-fixtures/Makefile

@@ -3,13 +3,13 @@
 default:
 	@for dir in $(shell find . -mindepth 1 -maxdepth 1 -type d); do \
 		if [ -f "$$dir/Makefile" ]; then \
-			$(MAKE) -C $$dir; \
+			$(MAKE) -C $$dir || exit 1; \
 		fi; \
 	done
 
 %:
 	@for dir in $(shell find . -mindepth 1 -maxdepth 1 -type d); do \
 		if [ -f "$$dir/Makefile" ]; then \
-			$(MAKE) -C $$dir $@; \
+			$(MAKE) -C $$dir $@ || exit 1; \
 		fi; \
 	done

syft/pkg/cataloger/java/test-fixtures/Makefile

@@ -3,13 +3,13 @@
 default:
 	@for dir in $(shell find . -mindepth 1 -maxdepth 1 -type d); do \
 		if [ -f "$$dir/Makefile" ]; then \
-			$(MAKE) -C $$dir; \
+			$(MAKE) -C $$dir || exit 1; \
 		fi; \
 	done
 
 %:
 	@for dir in $(shell find . -mindepth 1 -maxdepth 1 -type d); do \
 		if [ -f "$$dir/Makefile" ]; then \
-			$(MAKE) -C $$dir $@; \
+			$(MAKE) -C $$dir $@ || exit 1; \
 		fi; \
 	done

syft/pkg/cataloger/java/test-fixtures/java-builds/build-example-java-app-gradle.sh

@@ -11,7 +11,6 @@ function cleanup() {
 }
 
 trap cleanup EXIT
-set +e
 
 docker cp "$(pwd)/example-java-app" "${CTRID}:/"
 docker start -a "${CTRID}"

syft/pkg/cataloger/java/test-fixtures/java-builds/build-example-java-app-maven.sh

@@ -11,7 +11,6 @@ function cleanup() {
 }
 
 trap cleanup EXIT
-set +e
 
 docker cp "$(pwd)/example-java-app" "${CTRID}:/"
 docker start -a "${CTRID}"

syft/pkg/cataloger/java/test-fixtures/java-builds/build-example-java-app-native-image.sh

@@ -3,16 +3,14 @@ set -uxe
 
 PKGSDIR=$1
 
-CTRID=$(docker create -v /example-java-app ghcr.io/graalvm/native-image:22.2.0 -cp /example-java-app/example-java-app-maven-0.1.0.jar -XX:-UseContainerSupport --no-fallback -H:Class=hello.HelloWorld -H:Name=example-java-app)
+CTRID=$(docker create -v /example-java-app ghcr.io/graalvm/native-image:22.2.0 -J-XX:-UseContainerSupport -cp /example-java-app/example-java-app-maven-0.1.0.jar --no-fallback -H:Class=hello.HelloWorld -H:Name=example-java-app)
 
 function cleanup() {
   docker rm "${CTRID}"
 }
 
 trap cleanup EXIT
-set +e
 
 docker cp "${PKGSDIR}/example-java-app-maven-0.1.0.jar" "${CTRID}:/example-java-app/"
-
 docker start -a "${CTRID}"
-docker cp "${CTRID}:/app/example-java-app" $PKGSDIR
+docker cp "${CTRID}:/app/example-java-app" "$PKGSDIR"

syft/pkg/cataloger/java/test-fixtures/java-builds/build-example-jenkins-plugin.sh

@@ -11,7 +11,6 @@ function cleanup() {
 }
 
 trap cleanup EXIT
-set +e
 
 docker cp "$(pwd)/example-jenkins-plugin" "${CTRID}:/"
 docker start -a "${CTRID}"

syft/pkg/cataloger/java/test-fixtures/java-builds/build-example-sb-app-nestedjar.sh

@@ -11,7 +11,6 @@ function cleanup() {
 }
 
 trap cleanup EXIT
-set +e
 
 docker cp "$(pwd)/example-sb-app" "${CTRID}:/"
 docker start -a "${CTRID}"