improve config parsing + fix command deprecation warning

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>

internal/version/build.go

@@ -6,6 +6,7 @@ package version
 import (
 	"fmt"
 	"runtime"
+	"strings"
 )
 
 const valueNotProvided = "[not provided]"
@@ -28,6 +29,13 @@ type Version struct {
 	Platform     string `json:"platform"`     // GOOS and GOARCH at build-time
 }
 
+func (v Version) IsProductionBuild() bool {
+	if strings.Contains(v.Version, "SNAPSHOT") || strings.Contains(v.Version, valueNotProvided) {
+		return false
+	}
+	return true
+}
+
 // FromBuild provides all version details
 func FromBuild() Version {
 	return Version{

internal/version/update.go

@@ -20,13 +20,13 @@ var latestAppVersionURL = struct {
 
 // IsUpdateAvailable indicates if there is a newer application version available, and if so, what the new version is.
 func IsUpdateAvailable() (bool, string, error) {
-	currentVersionStr := FromBuild().Version
-	currentVersion, err := hashiVersion.NewVersion(currentVersionStr)
+	currentBuildInfo := FromBuild()
+	if !currentBuildInfo.IsProductionBuild() {
+		// don't allow for non-production builds to check for a version.
+		return false, "", nil
+	}
+	currentVersion, err := hashiVersion.NewVersion(currentBuildInfo.Version)
 	if err != nil {
-		if currentVersionStr == valueNotProvided {
-			// this is the default build arg and should be ignored (this is not an error case)
-			return false, "", nil
-		}
 		return false, "", fmt.Errorf("failed to parse current application version: %w", err)
 	}
 

internal/version/update_test.go

@@ -81,6 +81,15 @@ func TestIsUpdateAvailable(t *testing.T) {
 			newVersion:    "",
 			err:           false,
 		},
+		{
+			name:          "SnapshotBuildVersion",
+			buildVersion:  "2.0.0-SHAPSHOT-a78bf9c",
+			latestVersion: "1.0.0",
+			code:          200,
+			isAvailable:   false,
+			newVersion:    "",
+			err:           false,
+		},
 		{
 			name:          "BadUpdateValidVersion",
 			buildVersion:  "1.0.0",