mirror of
https://github.com/anchore/syft.git
synced 2025-11-18 00:43:20 +01:00
Fixes #931 PR #1948 introduces a new implicit exclusion for binary packages that overlap by file ownership and have certain characteristics: 1) the relationship between packages is OwnershipByFileOverlap 2) the parent package is an "os" package - see changelog for included catalogers 3) the child is a synthetic package generated by the binary cataloger - see changelog for included catalogers 4) the package names are identical --------- Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
88 lines
2.4 KiB
Go
88 lines
2.4 KiB
Go
package integration
|
|
|
|
import (
|
|
"bytes"
|
|
"encoding/json"
|
|
"testing"
|
|
|
|
"github.com/anchore/syft/syft/formats/syftjson"
|
|
syftjsonModel "github.com/anchore/syft/syft/formats/syftjson/model"
|
|
"github.com/anchore/syft/syft/pkg"
|
|
"github.com/anchore/syft/syft/source"
|
|
)
|
|
|
|
func TestPackageOwnershipRelationships(t *testing.T) {
|
|
// ensure that the json encoder is applying artifact ownership with an image that has expected ownership relationships
|
|
tests := []struct {
|
|
fixture string
|
|
}{
|
|
{
|
|
fixture: "image-owning-package",
|
|
},
|
|
}
|
|
|
|
for _, test := range tests {
|
|
t.Run(test.fixture, func(t *testing.T) {
|
|
sbom, _ := catalogFixtureImage(t, test.fixture, source.SquashedScope, nil)
|
|
|
|
output := bytes.NewBufferString("")
|
|
err := syftjson.Format().Encode(output, sbom)
|
|
if err != nil {
|
|
t.Fatalf("unable to present: %+v", err)
|
|
}
|
|
|
|
var doc syftjsonModel.Document
|
|
decoder := json.NewDecoder(output)
|
|
if err := decoder.Decode(&doc); err != nil {
|
|
t.Fatalf("unable to decode json doc: %+v", err)
|
|
}
|
|
|
|
if len(doc.ArtifactRelationships) == 0 {
|
|
t.Errorf("expected to find relationships between packages but found none")
|
|
}
|
|
|
|
})
|
|
}
|
|
|
|
}
|
|
|
|
func TestPackageOwnershipExclusions(t *testing.T) {
|
|
// ensure that the json encoder is excluding packages by artifact ownership with an image that has expected ownership relationships
|
|
tests := []struct {
|
|
name string
|
|
fixture string
|
|
}{
|
|
{
|
|
name: "busybox binary is filtered based on ownership relationship",
|
|
fixture: "image-os-binary-overlap",
|
|
},
|
|
}
|
|
|
|
for _, test := range tests {
|
|
t.Run(test.fixture, func(t *testing.T) {
|
|
sbom, _ := catalogFixtureImage(t, test.fixture, source.SquashedScope, nil)
|
|
binaryPackages := make([]pkg.Package, 0)
|
|
apkPackages := make([]pkg.Package, 0)
|
|
for p := range sbom.Artifacts.Packages.Enumerate() {
|
|
if p.Type == pkg.BinaryPkg && p.Name == "busybox" {
|
|
binaryPackages = append(binaryPackages, p)
|
|
}
|
|
if p.Type == pkg.ApkPkg && p.Name == "busybox" {
|
|
apkPackages = append(apkPackages, p)
|
|
}
|
|
}
|
|
|
|
if len(binaryPackages) != 0 {
|
|
packageNames := make([]string, 0)
|
|
for _, p := range binaryPackages {
|
|
packageNames = append(packageNames, p.Name)
|
|
}
|
|
t.Errorf("expected to find no binary packages but found %d packages: %v", len(binaryPackages), packageNames)
|
|
}
|
|
if len(apkPackages) == 0 {
|
|
t.Errorf("expected to find apk packages but found none")
|
|
}
|
|
})
|
|
}
|
|
}
|