mirror of
https://github.com/anchore/syft.git
synced 2026-10-11 21:57:22 +02:00
* ci: run the full unit suite on windows via make unit Drops the curated `unit:windows` subset; the windows job now bootstraps like linux and runs `make unit`. Exceptions get added as failures show up. Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * ci: skip fixture refresh for windows unit tests binny has no windows release, so the bootstrap action can't install the tools the fixture refresh needs. Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * test: skip linux container fixtures when docker can't run them Windows CI runners only run windows containers, so image fixtures go through `testutils.SkipWithoutLinuxContainers`. No behavior change on linux/mac. Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * fix: close leaked file handles and posix squashfs paths on windows - output writers are now closed on early returns in `scan`/`convert` (open handles block cleanup on windows) - `newSBOMMultiWriter` used `path.Dir` on host paths, so output subdirectories were never created on windows - squashfs walk paths were built with `filepath.Join` - skip a few posix-only test cases (dir perms, xdg fallback, go-rpmdb ndb handle leak upstream) Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * fix(golang): resolve go source module dir natively on windows - `parseGoModFile` passed the resolver's posix (`/c/...`) path to the go toolchain, so go source resolution silently found nothing on windows - skip container-built fixtures (go archs, java builds) and golden image tarballs on windows; stereoscope's layer cache filenames contain `:`, which windows rejects Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * fix: keep posix paths posix on windows - `ChrootContext.ToChrootPath` nested volumes (`D:\cwd\C:\root`) when the scan root was on another drive, so the prefix was never trimmed - bitnami, python wheel/egg, and alpm parsers used `filepath` on posix location paths - alpm backup-file lookups silently missed on windows Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * ci: pull the test fixture cache for windows unit tests Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * fix: don't map virtual file tree paths through the host on windows `FiletreeResolver` without a chroot (snaps) ran request paths through `filepath.Abs`, rooting them on the current volume (`/payload.txt` -> `/d/payload.txt`), so snap scans on windows found nothing. Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * fix: match tar entry globs as posix on windows - `matchesAnyGlob` used `doublestar.PathMatch` (host separator) on tar entry names, so tar-wrapped java archives silently produced nothing on windows - test helpers now treat binary snippet keys and `FromFile` locations as posix Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * incorporate windows path fix Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * incorporate go-rpmdb close fix Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * close squashfs fixture writers before finalizing - windows dir listings can report a zero size for files still open, so the manifest was packed empty (also adds a temporary windows diagnostic for the binary cataloger) Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * temp: surface windows binary cataloger diagnostics Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * fix: keep directory symlink targets posix on windows - the directory indexer joined symlink targets with native separators, so links in the posix file tree pointed nowhere and globs on link names found nothing - binary fixture logical keys used native separators, so nested snippets were picked as the fixture dir on windows Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * keep addSymlinkToIndex under the funlen limit Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * drop windows skips covered by the stereoscope and go-rpmdb bumps Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> --------- Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
297 lines
6.3 KiB
Go
297 lines
6.3 KiB
Go
package tmpdir
|
|
|
|
import (
|
|
"context"
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestRootAndFromContext(t *testing.T) {
|
|
ctx := context.Background()
|
|
assert.Nil(t, FromContext(ctx))
|
|
|
|
ctx, td := Root(ctx, "test")
|
|
require.NotNil(t, FromContext(ctx))
|
|
assert.Same(t, td, FromContext(ctx))
|
|
}
|
|
|
|
func TestWithValue(t *testing.T) {
|
|
_, td := Root(context.Background(), "test")
|
|
defer td.Cleanup()
|
|
|
|
// inject the existing TempDir into a fresh context
|
|
ctx := WithValue(context.Background(), td)
|
|
assert.Same(t, td, FromContext(ctx))
|
|
|
|
// the injected TempDir is fully functional
|
|
f, cleanup, err := FromContext(ctx).NewFile("with-value-*.txt")
|
|
require.NoError(t, err)
|
|
defer cleanup()
|
|
require.NoError(t, f.Close())
|
|
}
|
|
|
|
func TestNewChild(t *testing.T) {
|
|
ctx, td := Root(context.Background(), "test")
|
|
defer td.Cleanup()
|
|
_ = ctx
|
|
|
|
child1, cleanup1, err := td.NewChild("sub")
|
|
require.NoError(t, err)
|
|
defer cleanup1()
|
|
child2, cleanup2, err := td.NewChild("sub")
|
|
require.NoError(t, err)
|
|
defer cleanup2()
|
|
|
|
// children are distinct
|
|
assert.NotEqual(t, child1, child2)
|
|
|
|
// both exist and are under the same root
|
|
info1, err := os.Stat(child1)
|
|
require.NoError(t, err)
|
|
assert.True(t, info1.IsDir())
|
|
|
|
info2, err := os.Stat(child2)
|
|
require.NoError(t, err)
|
|
assert.True(t, info2.IsDir())
|
|
|
|
assert.Equal(t, filepath.Dir(child1), filepath.Dir(child2))
|
|
}
|
|
|
|
func TestNewFile(t *testing.T) {
|
|
_, td := Root(context.Background(), "test")
|
|
defer td.Cleanup()
|
|
|
|
f, cleanup, err := td.NewFile("hello-*.txt")
|
|
require.NoError(t, err)
|
|
defer cleanup()
|
|
|
|
_, err = f.WriteString("hello")
|
|
require.NoError(t, err)
|
|
require.NoError(t, f.Close())
|
|
|
|
content, err := os.ReadFile(f.Name())
|
|
require.NoError(t, err)
|
|
assert.Equal(t, "hello", string(content))
|
|
}
|
|
|
|
func TestCleanup(t *testing.T) {
|
|
_, td := Root(context.Background(), "test")
|
|
|
|
child, _, err := td.NewChild("sub")
|
|
require.NoError(t, err)
|
|
|
|
f, _, err := td.NewFile("file-*")
|
|
require.NoError(t, err)
|
|
fname := f.Name()
|
|
f.Close()
|
|
|
|
// write a file inside the child dir too
|
|
require.NoError(t, os.WriteFile(filepath.Join(child, "inner.txt"), []byte("x"), 0600))
|
|
|
|
// everything exists
|
|
_, err = os.Stat(child)
|
|
require.NoError(t, err)
|
|
_, err = os.Stat(fname)
|
|
require.NoError(t, err)
|
|
|
|
// cleanup
|
|
require.NoError(t, td.Cleanup())
|
|
|
|
// everything is gone
|
|
_, err = os.Stat(child)
|
|
assert.True(t, os.IsNotExist(err))
|
|
_, err = os.Stat(fname)
|
|
assert.True(t, os.IsNotExist(err))
|
|
|
|
// double cleanup is safe
|
|
require.NoError(t, td.Cleanup())
|
|
}
|
|
|
|
func TestCleanupPreventsNewAllocation(t *testing.T) {
|
|
_, td := Root(context.Background(), "test")
|
|
require.NoError(t, td.Cleanup())
|
|
|
|
_, _, err := td.NewChild("nope")
|
|
assert.Error(t, err)
|
|
|
|
_, _, err = td.NewFile("nope-*")
|
|
assert.Error(t, err)
|
|
}
|
|
|
|
func TestEarlyCleanupFile(t *testing.T) {
|
|
_, td := Root(context.Background(), "test")
|
|
defer td.Cleanup()
|
|
|
|
f, cleanup, err := td.NewFile("early-*.txt")
|
|
require.NoError(t, err)
|
|
|
|
fname := f.Name()
|
|
require.NoError(t, f.Close())
|
|
|
|
// file exists before cleanup
|
|
_, err = os.Stat(fname)
|
|
require.NoError(t, err)
|
|
|
|
// early cleanup removes the file
|
|
cleanup()
|
|
_, err = os.Stat(fname)
|
|
assert.True(t, os.IsNotExist(err))
|
|
|
|
// calling cleanup again is safe (idempotent)
|
|
cleanup()
|
|
}
|
|
|
|
func TestEarlyCleanupChild(t *testing.T) {
|
|
_, td := Root(context.Background(), "test")
|
|
defer td.Cleanup()
|
|
|
|
child, cleanup, err := td.NewChild("early")
|
|
require.NoError(t, err)
|
|
|
|
// child dir exists
|
|
_, err = os.Stat(child)
|
|
require.NoError(t, err)
|
|
|
|
// early cleanup removes it
|
|
cleanup()
|
|
_, err = os.Stat(child)
|
|
assert.True(t, os.IsNotExist(err))
|
|
|
|
// calling cleanup again is safe (idempotent)
|
|
cleanup()
|
|
}
|
|
|
|
func TestEarlyCleanupThenRootCleanup(t *testing.T) {
|
|
_, td := Root(context.Background(), "test")
|
|
|
|
f, cleanupFile, err := td.NewFile("combo-*.txt")
|
|
require.NoError(t, err)
|
|
fname := f.Name()
|
|
f.Close()
|
|
|
|
child, cleanupChild, err := td.NewChild("combo")
|
|
require.NoError(t, err)
|
|
|
|
// early cleanup both
|
|
cleanupFile()
|
|
cleanupChild()
|
|
|
|
// files are already gone
|
|
_, err = os.Stat(fname)
|
|
assert.True(t, os.IsNotExist(err))
|
|
_, err = os.Stat(child)
|
|
assert.True(t, os.IsNotExist(err))
|
|
|
|
// root cleanup still works (no error on already-removed contents)
|
|
require.NoError(t, td.Cleanup())
|
|
}
|
|
|
|
func TestConcurrentNewChildAndNewFile(t *testing.T) {
|
|
_, td := Root(context.Background(), "test")
|
|
defer td.Cleanup()
|
|
|
|
const goroutines = 20
|
|
errs := make(chan error, goroutines)
|
|
paths := make(chan string, goroutines)
|
|
|
|
for i := range goroutines {
|
|
go func(i int) {
|
|
if i%2 == 0 {
|
|
child, cleanup, err := td.NewChild("concurrent")
|
|
if err != nil {
|
|
errs <- err
|
|
return
|
|
}
|
|
defer cleanup()
|
|
paths <- child
|
|
} else {
|
|
f, cleanup, err := td.NewFile("concurrent-*.txt")
|
|
if err != nil {
|
|
errs <- err
|
|
return
|
|
}
|
|
defer cleanup()
|
|
_ = f.Close()
|
|
paths <- f.Name()
|
|
}
|
|
errs <- nil
|
|
}(i)
|
|
}
|
|
|
|
seen := make(map[string]bool)
|
|
for range goroutines {
|
|
err := <-errs
|
|
require.NoError(t, err)
|
|
}
|
|
close(paths)
|
|
for p := range paths {
|
|
assert.False(t, seen[p], "duplicate path: %s", p)
|
|
seen[p] = true
|
|
}
|
|
assert.Len(t, seen, goroutines)
|
|
}
|
|
|
|
func TestConcurrentNewChildDuringCleanup(t *testing.T) {
|
|
_, td := Root(context.Background(), "test")
|
|
|
|
// trigger root creation
|
|
_, cleanup, err := td.NewChild("init")
|
|
require.NoError(t, err)
|
|
cleanup()
|
|
|
|
// cleanup and concurrent NewChild should not panic
|
|
done := make(chan struct{})
|
|
go func() {
|
|
_ = td.Cleanup()
|
|
close(done)
|
|
}()
|
|
// try creating children concurrently with cleanup — should get errors, not panics
|
|
for range 10 {
|
|
_, c, _ := td.NewChild("race")
|
|
if c != nil {
|
|
c()
|
|
}
|
|
}
|
|
<-done
|
|
}
|
|
|
|
func TestLazyCreation(t *testing.T) {
|
|
_, td := Root(context.Background(), "test")
|
|
|
|
// root dir is not created until needed
|
|
assert.Equal(t, "", td.root)
|
|
|
|
f, _, err := td.NewFile("trigger-*")
|
|
require.NoError(t, err)
|
|
require.NoError(t, f.Close())
|
|
|
|
assert.NotEmpty(t, td.root)
|
|
|
|
require.NoError(t, td.Cleanup())
|
|
}
|
|
|
|
func TestFromPath(t *testing.T) {
|
|
dir := t.TempDir()
|
|
td := FromPath(dir)
|
|
|
|
// can create children
|
|
child, cleanup, err := td.NewChild("sub")
|
|
require.NoError(t, err)
|
|
defer cleanup()
|
|
assert.DirExists(t, child)
|
|
|
|
// can create files
|
|
f, cleanupFile, err := td.NewFile("file-*.txt")
|
|
require.NoError(t, err)
|
|
defer cleanupFile()
|
|
require.NoError(t, f.Close())
|
|
assert.FileExists(t, f.Name())
|
|
|
|
// root is the provided dir
|
|
assert.Equal(t, dir, filepath.Dir(child))
|
|
}
|