mirror of
https://github.com/anchore/syft.git
synced 2026-10-30 22:12:28 +01:00
* ci: run the full unit suite on windows via make unit Drops the curated `unit:windows` subset; the windows job now bootstraps like linux and runs `make unit`. Exceptions get added as failures show up. Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * ci: skip fixture refresh for windows unit tests binny has no windows release, so the bootstrap action can't install the tools the fixture refresh needs. Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * test: skip linux container fixtures when docker can't run them Windows CI runners only run windows containers, so image fixtures go through `testutils.SkipWithoutLinuxContainers`. No behavior change on linux/mac. Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * fix: close leaked file handles and posix squashfs paths on windows - output writers are now closed on early returns in `scan`/`convert` (open handles block cleanup on windows) - `newSBOMMultiWriter` used `path.Dir` on host paths, so output subdirectories were never created on windows - squashfs walk paths were built with `filepath.Join` - skip a few posix-only test cases (dir perms, xdg fallback, go-rpmdb ndb handle leak upstream) Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * fix(golang): resolve go source module dir natively on windows - `parseGoModFile` passed the resolver's posix (`/c/...`) path to the go toolchain, so go source resolution silently found nothing on windows - skip container-built fixtures (go archs, java builds) and golden image tarballs on windows; stereoscope's layer cache filenames contain `:`, which windows rejects Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * fix: keep posix paths posix on windows - `ChrootContext.ToChrootPath` nested volumes (`D:\cwd\C:\root`) when the scan root was on another drive, so the prefix was never trimmed - bitnami, python wheel/egg, and alpm parsers used `filepath` on posix location paths - alpm backup-file lookups silently missed on windows Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * ci: pull the test fixture cache for windows unit tests Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * fix: don't map virtual file tree paths through the host on windows `FiletreeResolver` without a chroot (snaps) ran request paths through `filepath.Abs`, rooting them on the current volume (`/payload.txt` -> `/d/payload.txt`), so snap scans on windows found nothing. Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * fix: match tar entry globs as posix on windows - `matchesAnyGlob` used `doublestar.PathMatch` (host separator) on tar entry names, so tar-wrapped java archives silently produced nothing on windows - test helpers now treat binary snippet keys and `FromFile` locations as posix Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * incorporate windows path fix Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * incorporate go-rpmdb close fix Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * close squashfs fixture writers before finalizing - windows dir listings can report a zero size for files still open, so the manifest was packed empty (also adds a temporary windows diagnostic for the binary cataloger) Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * temp: surface windows binary cataloger diagnostics Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * fix: keep directory symlink targets posix on windows - the directory indexer joined symlink targets with native separators, so links in the posix file tree pointed nowhere and globs on link names found nothing - binary fixture logical keys used native separators, so nested snippets were picked as the fixture dir on windows Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * keep addSymlinkToIndex under the funlen limit Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * drop windows skips covered by the stereoscope and go-rpmdb bumps Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> --------- Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
253 lines
6.2 KiB
Go
253 lines
6.2 KiB
Go
package file
|
|
|
|
import (
|
|
"io/fs"
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"github.com/diskfs/go-diskfs/backend/file"
|
|
"github.com/diskfs/go-diskfs/filesystem"
|
|
"github.com/diskfs/go-diskfs/filesystem/squashfs"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func createTestFS(t *testing.T) filesystem.FileSystem {
|
|
dir := t.TempDir()
|
|
|
|
filename := "test.squashfs"
|
|
f, err := os.Create(filepath.Join(dir, filename))
|
|
require.NoError(t, err)
|
|
// windows can't remove the temp dir while the backing file is open
|
|
t.Cleanup(func() { _ = f.Close() })
|
|
|
|
b := file.New(f, false)
|
|
fsys, err := squashfs.Create(b, 0, 0, 4096)
|
|
require.NoError(t, err)
|
|
|
|
testFiles := []struct {
|
|
path string
|
|
content string
|
|
isDir bool
|
|
}{
|
|
{"/file1.txt", "content of file1", false},
|
|
{"/file2.txt", "content of file2", false},
|
|
{"/dir1", "", true},
|
|
{"/dir1/subfile1.txt", "content of subfile1", false},
|
|
{"/dir1/subfile2.txt", "content of subfile2", false},
|
|
{"/dir1/subdir1", "", true},
|
|
{"/dir1/subdir1/deepfile.txt", "deep content", false},
|
|
{"/dir2", "", true},
|
|
{"/dir2/anotherfile.txt", "another content", false},
|
|
{"/emptydir", "", true},
|
|
}
|
|
|
|
for _, tf := range testFiles {
|
|
if tf.isDir {
|
|
err := fsys.Mkdir(ToFSPath(tf.path))
|
|
require.NoError(t, err)
|
|
} else {
|
|
f, err := fsys.OpenFile(ToFSPath(tf.path), os.O_CREATE|os.O_RDWR)
|
|
require.NoError(t, err)
|
|
_, err = f.Write([]byte(tf.content))
|
|
require.NoError(t, err)
|
|
f.Close()
|
|
}
|
|
}
|
|
|
|
return fsys
|
|
}
|
|
|
|
func TestWalkDiskDir_CompleteTraversal(t *testing.T) {
|
|
fsys := createTestFS(t)
|
|
|
|
var visitedPaths []string
|
|
err := WalkDiskDir(fsys, "/", func(fsys filesystem.FileSystem, path string, d os.FileInfo, err error) error {
|
|
require.NoError(t, err)
|
|
visitedPaths = append(visitedPaths, path)
|
|
return nil
|
|
})
|
|
|
|
require.NoError(t, err)
|
|
|
|
expectedPaths := []string{
|
|
"/file1.txt",
|
|
"/file2.txt",
|
|
"/dir1",
|
|
"/dir1/subfile1.txt",
|
|
"/dir1/subfile2.txt",
|
|
"/dir1/subdir1",
|
|
"/dir1/subdir1/deepfile.txt",
|
|
"/dir2",
|
|
"/dir2/anotherfile.txt",
|
|
"/emptydir",
|
|
}
|
|
|
|
assert.ElementsMatch(t, expectedPaths, visitedPaths)
|
|
}
|
|
|
|
func TestWalkDiskDir_FileInfoCorrect(t *testing.T) {
|
|
fsys := createTestFS(t)
|
|
|
|
var fileInfos []struct {
|
|
path string
|
|
isDir bool
|
|
name string
|
|
}
|
|
|
|
err := WalkDiskDir(fsys, "/", func(fsys filesystem.FileSystem, path string, d os.FileInfo, err error) error {
|
|
require.NoError(t, err)
|
|
require.NotNil(t, d)
|
|
fileInfos = append(fileInfos, struct {
|
|
path string
|
|
isDir bool
|
|
name string
|
|
}{
|
|
path: path,
|
|
isDir: d.IsDir(),
|
|
name: d.Name(),
|
|
})
|
|
return nil
|
|
})
|
|
|
|
require.NoError(t, err)
|
|
|
|
for _, fi := range fileInfos {
|
|
expectedName := filepath.Base(fi.path)
|
|
assert.Equal(t, expectedName, fi.name)
|
|
|
|
if fi.path == "/dir1" || fi.path == "/dir2" || fi.path == "/emptydir" || fi.path == "/dir1/subdir1" {
|
|
assert.True(t, fi.isDir, "Expected %s to be directory", fi.path)
|
|
} else {
|
|
assert.False(t, fi.isDir, "Expected %s to be file", fi.path)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestWalkDiskDir_SkipDir(t *testing.T) {
|
|
fsys := createTestFS(t)
|
|
|
|
var visitedPaths []string
|
|
err := WalkDiskDir(fsys, "/", func(fsys filesystem.FileSystem, path string, d os.FileInfo, err error) error {
|
|
require.NoError(t, err)
|
|
visitedPaths = append(visitedPaths, path)
|
|
if path == "/dir1" {
|
|
return fs.SkipDir
|
|
}
|
|
return nil
|
|
})
|
|
|
|
require.NoError(t, err)
|
|
|
|
assert.Contains(t, visitedPaths, "/dir1")
|
|
assert.NotContains(t, visitedPaths, "/dir1/subfile1.txt")
|
|
assert.NotContains(t, visitedPaths, "/dir1/subfile2.txt")
|
|
assert.NotContains(t, visitedPaths, "/dir1/subdir1")
|
|
assert.NotContains(t, visitedPaths, "/dir1/subdir1/deepfile.txt")
|
|
|
|
assert.Contains(t, visitedPaths, "/dir2")
|
|
assert.Contains(t, visitedPaths, "/dir2/anotherfile.txt")
|
|
}
|
|
|
|
func TestWalkDiskDir_SkipAll(t *testing.T) {
|
|
fsys := createTestFS(t)
|
|
|
|
var visitedPaths []string
|
|
err := WalkDiskDir(fsys, "/", func(fsys filesystem.FileSystem, path string, d os.FileInfo, err error) error {
|
|
require.NoError(t, err)
|
|
visitedPaths = append(visitedPaths, path)
|
|
if path == "/dir1" {
|
|
return fs.SkipAll
|
|
}
|
|
return nil
|
|
})
|
|
|
|
require.NoError(t, err)
|
|
|
|
assert.Contains(t, visitedPaths, "/dir1")
|
|
|
|
assert.NotContains(t, visitedPaths, "/file1.txt")
|
|
assert.NotContains(t, visitedPaths, "/file2.txt")
|
|
assert.NotContains(t, visitedPaths, "/dir1/subfile1.txt")
|
|
assert.NotContains(t, visitedPaths, "/dir2")
|
|
assert.NotContains(t, visitedPaths, "/dir2/anotherfile.txt")
|
|
assert.NotContains(t, visitedPaths, "/emptydir")
|
|
}
|
|
|
|
func TestWalkDiskDir_EmptyDirectory(t *testing.T) {
|
|
fs := createTestFS(t)
|
|
|
|
var visitedPaths []string
|
|
err := WalkDiskDir(fs, "/emptydir", func(fsys filesystem.FileSystem, path string, d os.FileInfo, err error) error {
|
|
require.NoError(t, err)
|
|
visitedPaths = append(visitedPaths, path)
|
|
return nil
|
|
})
|
|
|
|
require.NoError(t, err)
|
|
assert.Empty(t, visitedPaths)
|
|
}
|
|
|
|
func TestWalkDiskDir_NonexistentPath(t *testing.T) {
|
|
fs := createTestFS(t)
|
|
|
|
err := WalkDiskDir(fs, "/nonexistent", func(fsys filesystem.FileSystem, path string, d os.FileInfo, err error) error {
|
|
return nil
|
|
})
|
|
|
|
assert.Error(t, err)
|
|
}
|
|
|
|
func TestWalkDiskDir_WalkFunctionError(t *testing.T) {
|
|
fs := createTestFS(t)
|
|
|
|
customErr := assert.AnError
|
|
err := WalkDiskDir(fs, "/", func(fsys filesystem.FileSystem, path string, d os.FileInfo, err error) error {
|
|
if path == "/file1.txt" {
|
|
return customErr
|
|
}
|
|
return nil
|
|
})
|
|
|
|
assert.Error(t, err)
|
|
assert.Equal(t, customErr, err)
|
|
}
|
|
|
|
func TestWalkDiskDir_SubdirectoryTraversal(t *testing.T) {
|
|
fs := createTestFS(t)
|
|
|
|
var visitedPaths []string
|
|
err := WalkDiskDir(fs, "/dir1", func(fsys filesystem.FileSystem, path string, d os.FileInfo, err error) error {
|
|
require.NoError(t, err)
|
|
visitedPaths = append(visitedPaths, path)
|
|
return nil
|
|
})
|
|
|
|
require.NoError(t, err)
|
|
|
|
expectedPaths := []string{
|
|
"/dir1/subfile1.txt",
|
|
"/dir1/subfile2.txt",
|
|
"/dir1/subdir1",
|
|
"/dir1/subdir1/deepfile.txt",
|
|
}
|
|
|
|
assert.ElementsMatch(t, expectedPaths, visitedPaths)
|
|
}
|
|
|
|
func TestWalkDiskDir_SingleFile(t *testing.T) {
|
|
fs := createTestFS(t)
|
|
|
|
var visitedPaths []string
|
|
err := WalkDiskDir(fs, "/file1.txt", func(fsys filesystem.FileSystem, path string, d os.FileInfo, err error) error {
|
|
require.NoError(t, err)
|
|
visitedPaths = append(visitedPaths, path)
|
|
return nil
|
|
})
|
|
|
|
// we are providing a file path, not a directory
|
|
require.Error(t, err)
|
|
assert.Empty(t, visitedPaths)
|
|
}
|