mirror of
https://github.com/anchore/syft.git
synced 2026-11-03 16:06:36 +01:00
* ci: run the full unit suite on windows via make unit Drops the curated `unit:windows` subset; the windows job now bootstraps like linux and runs `make unit`. Exceptions get added as failures show up. Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * ci: skip fixture refresh for windows unit tests binny has no windows release, so the bootstrap action can't install the tools the fixture refresh needs. Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * test: skip linux container fixtures when docker can't run them Windows CI runners only run windows containers, so image fixtures go through `testutils.SkipWithoutLinuxContainers`. No behavior change on linux/mac. Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * fix: close leaked file handles and posix squashfs paths on windows - output writers are now closed on early returns in `scan`/`convert` (open handles block cleanup on windows) - `newSBOMMultiWriter` used `path.Dir` on host paths, so output subdirectories were never created on windows - squashfs walk paths were built with `filepath.Join` - skip a few posix-only test cases (dir perms, xdg fallback, go-rpmdb ndb handle leak upstream) Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * fix(golang): resolve go source module dir natively on windows - `parseGoModFile` passed the resolver's posix (`/c/...`) path to the go toolchain, so go source resolution silently found nothing on windows - skip container-built fixtures (go archs, java builds) and golden image tarballs on windows; stereoscope's layer cache filenames contain `:`, which windows rejects Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * fix: keep posix paths posix on windows - `ChrootContext.ToChrootPath` nested volumes (`D:\cwd\C:\root`) when the scan root was on another drive, so the prefix was never trimmed - bitnami, python wheel/egg, and alpm parsers used `filepath` on posix location paths - alpm backup-file lookups silently missed on windows Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * ci: pull the test fixture cache for windows unit tests Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * fix: don't map virtual file tree paths through the host on windows `FiletreeResolver` without a chroot (snaps) ran request paths through `filepath.Abs`, rooting them on the current volume (`/payload.txt` -> `/d/payload.txt`), so snap scans on windows found nothing. Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * fix: match tar entry globs as posix on windows - `matchesAnyGlob` used `doublestar.PathMatch` (host separator) on tar entry names, so tar-wrapped java archives silently produced nothing on windows - test helpers now treat binary snippet keys and `FromFile` locations as posix Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * incorporate windows path fix Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * incorporate go-rpmdb close fix Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * close squashfs fixture writers before finalizing - windows dir listings can report a zero size for files still open, so the manifest was packed empty (also adds a temporary windows diagnostic for the binary cataloger) Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * temp: surface windows binary cataloger diagnostics Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * fix: keep directory symlink targets posix on windows - the directory indexer joined symlink targets with native separators, so links in the posix file tree pointed nowhere and globs on link names found nothing - binary fixture logical keys used native separators, so nested snippets were picked as the fixture dir on windows Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * keep addSymlinkToIndex under the funlen limit Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * drop windows skips covered by the stereoscope and go-rpmdb bumps Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> --------- Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
223 lines
5.5 KiB
Go
223 lines
5.5 KiB
Go
package filemetadata
|
|
|
|
import (
|
|
"context"
|
|
"os"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
stereoscopeFile "github.com/anchore/stereoscope/pkg/file"
|
|
"github.com/anchore/stereoscope/pkg/imagetest"
|
|
"github.com/anchore/syft/internal/testutils"
|
|
"github.com/anchore/syft/syft/file"
|
|
"github.com/anchore/syft/syft/source"
|
|
"github.com/anchore/syft/syft/source/stereoscopesource"
|
|
)
|
|
|
|
func TestFileMetadataCataloger(t *testing.T) {
|
|
testImage := "image-file-type-mix"
|
|
|
|
testutils.SkipWithoutLinuxContainers(t)
|
|
img := imagetest.GetFixtureImage(t, "docker-archive", testImage)
|
|
|
|
c := NewCataloger()
|
|
|
|
src := stereoscopesource.New(img, stereoscopesource.ImageConfig{
|
|
Reference: testImage,
|
|
})
|
|
|
|
resolver, err := src.FileResolver(source.SquashedScope)
|
|
require.NoError(t, err)
|
|
|
|
actual, err := c.Catalog(context.Background(), resolver)
|
|
require.NoError(t, err)
|
|
|
|
tests := []struct {
|
|
path string
|
|
exists bool
|
|
expected file.Metadata
|
|
err bool
|
|
}{
|
|
// note: it is difficult to add a hardlink-based test in a cross-platform way and is already covered well in stereoscope
|
|
{
|
|
path: "/file-1.txt",
|
|
exists: true,
|
|
expected: file.Metadata{
|
|
FileInfo: stereoscopeFile.ManualInfo{
|
|
NameValue: "file-1.txt",
|
|
ModeValue: 0644,
|
|
SizeValue: 7,
|
|
},
|
|
Path: "/file-1.txt",
|
|
Type: stereoscopeFile.TypeRegular,
|
|
UserID: 1,
|
|
GroupID: 2,
|
|
MIMEType: "text/plain",
|
|
},
|
|
},
|
|
{
|
|
path: "/symlink-1",
|
|
exists: true,
|
|
expected: file.Metadata{
|
|
Path: "/symlink-1",
|
|
FileInfo: stereoscopeFile.ManualInfo{
|
|
NameValue: "symlink-1",
|
|
ModeValue: 0777 | os.ModeSymlink,
|
|
},
|
|
Type: stereoscopeFile.TypeSymLink,
|
|
LinkDestination: "file-1.txt",
|
|
UserID: 0,
|
|
GroupID: 0,
|
|
MIMEType: "",
|
|
},
|
|
},
|
|
{
|
|
path: "/char-device-1",
|
|
exists: true,
|
|
expected: file.Metadata{
|
|
Path: "/char-device-1",
|
|
FileInfo: stereoscopeFile.ManualInfo{
|
|
NameValue: "char-device-1",
|
|
ModeValue: 0644 | os.ModeDevice | os.ModeCharDevice,
|
|
},
|
|
Type: stereoscopeFile.TypeCharacterDevice,
|
|
UserID: 0,
|
|
GroupID: 0,
|
|
MIMEType: "",
|
|
},
|
|
},
|
|
{
|
|
path: "/block-device-1",
|
|
exists: true,
|
|
expected: file.Metadata{
|
|
Path: "/block-device-1",
|
|
FileInfo: stereoscopeFile.ManualInfo{
|
|
NameValue: "block-device-1",
|
|
ModeValue: 0644 | os.ModeDevice,
|
|
},
|
|
Type: stereoscopeFile.TypeBlockDevice,
|
|
UserID: 0,
|
|
GroupID: 0,
|
|
MIMEType: "",
|
|
},
|
|
},
|
|
{
|
|
path: "/fifo-1",
|
|
exists: true,
|
|
expected: file.Metadata{
|
|
Path: "/fifo-1",
|
|
FileInfo: stereoscopeFile.ManualInfo{
|
|
NameValue: "fifo-1",
|
|
ModeValue: 0644 | os.ModeNamedPipe,
|
|
},
|
|
Type: stereoscopeFile.TypeFIFO,
|
|
UserID: 0,
|
|
GroupID: 0,
|
|
MIMEType: "",
|
|
},
|
|
},
|
|
{
|
|
path: "/bin",
|
|
exists: true,
|
|
expected: file.Metadata{
|
|
Path: "/bin",
|
|
FileInfo: stereoscopeFile.ManualInfo{
|
|
NameValue: "bin",
|
|
ModeValue: 0755 | os.ModeDir,
|
|
},
|
|
Type: stereoscopeFile.TypeDirectory,
|
|
UserID: 0,
|
|
GroupID: 0,
|
|
MIMEType: "",
|
|
},
|
|
},
|
|
}
|
|
|
|
for _, test := range tests {
|
|
t.Run(test.path, func(t *testing.T) {
|
|
_, ref, err := img.SquashedTree().File(stereoscopeFile.Path(test.path))
|
|
require.NoError(t, err)
|
|
|
|
l := file.NewLocationFromImage(test.path, *ref.Reference, img)
|
|
|
|
if _, ok := actual[l.Coordinates]; ok {
|
|
// we're not interested in keeping the test fixtures up to date with the latest file modification times
|
|
// thus ModTime is not under test
|
|
fi := test.expected.FileInfo.(stereoscopeFile.ManualInfo)
|
|
fi.ModTimeValue = actual[l.Coordinates].ModTime()
|
|
test.expected.FileInfo = fi
|
|
}
|
|
|
|
assert.True(t, test.expected.Equal(actual[l.Coordinates]))
|
|
})
|
|
}
|
|
|
|
}
|
|
|
|
func TestFileMetadataCataloger_GivenCoordinates(t *testing.T) {
|
|
testImage := "image-file-type-mix"
|
|
|
|
testutils.SkipWithoutLinuxContainers(t)
|
|
img := imagetest.GetFixtureImage(t, "docker-archive", testImage)
|
|
|
|
c := NewCataloger()
|
|
|
|
src := stereoscopesource.New(img, stereoscopesource.ImageConfig{
|
|
Reference: testImage,
|
|
})
|
|
|
|
resolver, err := src.FileResolver(source.SquashedScope)
|
|
require.NoError(t, err)
|
|
|
|
tests := []struct {
|
|
path string
|
|
exists bool
|
|
expected file.Metadata
|
|
}{
|
|
{
|
|
path: "/file-1.txt",
|
|
exists: true,
|
|
expected: file.Metadata{
|
|
FileInfo: stereoscopeFile.ManualInfo{
|
|
NameValue: "file-1.txt",
|
|
ModeValue: 0644,
|
|
SizeValue: 7,
|
|
},
|
|
Path: "/file-1.txt",
|
|
Type: stereoscopeFile.TypeRegular,
|
|
UserID: 1,
|
|
GroupID: 2,
|
|
MIMEType: "text/plain",
|
|
},
|
|
},
|
|
}
|
|
|
|
for _, test := range tests {
|
|
t.Run(test.path, func(t *testing.T) {
|
|
_, ref, err := img.SquashedTree().File(stereoscopeFile.Path(test.path))
|
|
require.NoError(t, err)
|
|
|
|
l := file.NewLocationFromImage(test.path, *ref.Reference, img)
|
|
|
|
// note: an important difference between this test and the previous is that this test is using a list
|
|
// of specific coordinates to catalog
|
|
actual, err := c.Catalog(context.Background(), resolver, l.Coordinates)
|
|
require.NoError(t, err)
|
|
require.Len(t, actual, 1)
|
|
|
|
if _, ok := actual[l.Coordinates]; ok {
|
|
// we're not interested in keeping the test fixtures up to date with the latest file modification times
|
|
// thus ModTime is not under test
|
|
fi := test.expected.FileInfo.(stereoscopeFile.ManualInfo)
|
|
fi.ModTimeValue = actual[l.Coordinates].ModTime()
|
|
test.expected.FileInfo = fi
|
|
}
|
|
|
|
assert.True(t, test.expected.Equal(actual[l.Coordinates]))
|
|
})
|
|
}
|
|
|
|
}
|