mirror of
https://github.com/anchore/syft.git
synced 2026-11-03 07:56:36 +01:00
* migrate fixtures to testdata Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * fix: correct broken symlinks after testdata migration The migration from test-fixtures to testdata broke several symlinks: - elf-test-fixtures symlinks pointed to old test-fixtures paths - elf-test-fixtures needed to be renamed to elf-testdata - image-pkg-coverage symlink pointed to test-fixtures instead of testdata Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * fix: handle missing classifiers/bin directory in Makefile The clean-fingerprint target was failing when classifiers/bin doesn't exist (e.g., on fresh clone without downloaded binaries). Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * fix: add gitignore negation for jar/zip fixtures in test/cli The jar and zip files in test/cli/testdata/image-unknowns were being gitignored by the root .gitignore patterns. This caused them to be untracked and not included when building docker images in CI, resulting in Test_Unknowns failures since the test expects errors from corrupt archive files that weren't present. Add a .gitignore in test/cli/testdata to negate the exclusions for these specific test fixture files. Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * switch fixture cache to v2 Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * test: update expected versions for rebuilt fixtures Update test expectations for packages that have been updated in upstream repositories when docker images are rebuilt: - glibc: 2.42-r4 → 2.43-r1 (wolfi) - php: 8.2.29 → 8.2.30 (ubuntu/apache) Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * upgrade go Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * fix: add go-shlex dependency for testdata manager tool The manager tool in syft/pkg/cataloger/binary/testdata/ imports go-shlex, but since it's in a testdata directory, Go doesn't track its dependencies. This caused CI failures when go.mod didn't explicitly list the dependency. Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * refactor: move binary classifier manager to internal/ Move the manager tool from testdata/manager to internal/manager so that Go properly tracks its dependencies. Code in testdata directories is ignored by Go for dependency tracking, which caused CI failures when go.mod didn't explicitly list transitive dependencies. This is a cleaner solution than manually adding dependencies to go.mod for code that happens to live in testdata. Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * fix: add gitignore negations for test fixtures blocked by root patterns Multiple test fixtures were being blocked by root-level gitignore patterns like bin/, *.jar, *.tar, and *.exe. This adds targeted .gitignore files with negation patterns to allow these specific test fixtures to be tracked: - syft/linux/testdata/os/busybox/bin/busybox (blocked by bin/) - syft/pkg/cataloger/java/testdata/corrupt/example.{jar,tar} (blocked by *.jar, *.tar) - syft/pkg/cataloger/binary/testdata/classifiers/snippets/go-version-hint/**/bin/go (blocked by bin/) - syft/pkg/cataloger/bitnami/testdata/no-rel/.../bin/redis-server (blocked by bin/) Also updates the bitnami test expectation to include the newly required .gitignore files in the test fixture. Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * test: update glibc version expectation (2.43-r1 -> 2.43-r2) Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * add capability drift check as unit step Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * dont clear test observations before drift detection Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> * bump stereoscope commit to main Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> --------- Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
325 lines
12 KiB
Go
325 lines
12 KiB
Go
package debian
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
|
|
"github.com/google/go-cmp/cmp"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/anchore/syft/syft/file"
|
|
"github.com/anchore/syft/syft/pkg"
|
|
"github.com/anchore/syft/syft/pkg/cataloger/internal/pkgtest"
|
|
)
|
|
|
|
func TestDpkgCataloger(t *testing.T) {
|
|
ctx := context.TODO()
|
|
tests := []struct {
|
|
name string
|
|
expected []pkg.Package
|
|
}{
|
|
{
|
|
name: "image-dpkg",
|
|
expected: []pkg.Package{
|
|
{
|
|
Name: "libpam-runtime",
|
|
Version: "1.1.8-3.6",
|
|
FoundBy: "dpkg-db-cataloger",
|
|
Licenses: pkg.NewLicenseSet(
|
|
pkg.NewLicenseFromLocationsWithContext(ctx, "GPL-1", file.NewLocation("/usr/share/doc/libpam-runtime/copyright")),
|
|
pkg.NewLicenseFromLocationsWithContext(ctx, "GPL-2", file.NewLocation("/usr/share/doc/libpam-runtime/copyright")),
|
|
pkg.NewLicenseFromLocationsWithContext(ctx, "LGPL-2.1", file.NewLocation("/usr/share/doc/libpam-runtime/copyright")),
|
|
),
|
|
Locations: file.NewLocationSet(
|
|
file.NewLocation("/var/lib/dpkg/status").WithAnnotation(pkg.EvidenceAnnotationKey, pkg.PrimaryEvidenceAnnotation),
|
|
file.NewLocation("/var/lib/dpkg/info/libpam-runtime.preinst").WithAnnotation(pkg.EvidenceAnnotationKey, pkg.SupportingEvidenceAnnotation),
|
|
file.NewLocation("/var/lib/dpkg/info/libpam-runtime.md5sums").WithAnnotation(pkg.EvidenceAnnotationKey, pkg.SupportingEvidenceAnnotation),
|
|
file.NewLocation("/var/lib/dpkg/info/libpam-runtime.conffiles").WithAnnotation(pkg.EvidenceAnnotationKey, pkg.SupportingEvidenceAnnotation),
|
|
file.NewLocation("/usr/share/doc/libpam-runtime/copyright").WithAnnotation(pkg.EvidenceAnnotationKey, pkg.SupportingEvidenceAnnotation),
|
|
),
|
|
PURL: "pkg:deb/debian/libpam-runtime@1.1.8-3.6?arch=all&distro=debian-12&upstream=pam",
|
|
Type: pkg.DebPkg,
|
|
Metadata: pkg.DpkgDBEntry{
|
|
Package: "libpam-runtime",
|
|
Source: "pam",
|
|
Version: "1.1.8-3.6",
|
|
Architecture: "all",
|
|
Maintainer: "Steve Langasek <vorlon@debian.org>",
|
|
InstalledSize: 1016,
|
|
Description: `Runtime support for the PAM library
|
|
Contains configuration files and directories required for
|
|
authentication to work on Debian systems. This package is required
|
|
on almost all installations.`,
|
|
Depends: []string{
|
|
"debconf (>= 0.5) | debconf-2.0",
|
|
"debconf (>= 1.5.19) | cdebconf",
|
|
"libpam-modules (>= 1.0.1-6)",
|
|
},
|
|
Files: []pkg.DpkgFileRecord{
|
|
{
|
|
Path: "/etc/pam.conf",
|
|
Digest: &file.Digest{
|
|
Algorithm: "md5",
|
|
Value: "87fc76f18e98ee7d3848f6b81b3391e5",
|
|
},
|
|
IsConfigFile: true,
|
|
},
|
|
{
|
|
Path: "/etc/pam.d/other",
|
|
Digest: &file.Digest{
|
|
Algorithm: "md5",
|
|
Value: "31aa7f2181889ffb00b87df4126d1701",
|
|
},
|
|
IsConfigFile: true,
|
|
},
|
|
{Path: "/lib/x86_64-linux-gnu/libz.so.1.2.11", Digest: &file.Digest{
|
|
Algorithm: "md5",
|
|
Value: "55f905631797551d4d936a34c7e73474",
|
|
}},
|
|
{Path: "/usr/share/doc/zlib1g/changelog.Debian.gz", Digest: &file.Digest{
|
|
Algorithm: "md5",
|
|
Value: "cede84bda30d2380217f97753c8ccf3a",
|
|
}},
|
|
{Path: "/usr/share/doc/zlib1g/changelog.gz", Digest: &file.Digest{
|
|
Algorithm: "md5",
|
|
Value: "f3c9dafa6da7992c47328b4464f6d122",
|
|
}},
|
|
{Path: "/usr/share/doc/zlib1g/copyright", Digest: &file.Digest{
|
|
Algorithm: "md5",
|
|
Value: "a4fae96070439a5209a62ae5b8017ab2",
|
|
}},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "image-distroless-deb",
|
|
expected: []pkg.Package{
|
|
{
|
|
Name: "libsqlite3-0",
|
|
Version: "3.34.1-3",
|
|
FoundBy: "dpkg-db-cataloger",
|
|
Licenses: pkg.NewLicenseSet(
|
|
pkg.NewLicenseFromLocationsWithContext(ctx, "public-domain", file.NewLocation("/usr/share/doc/libsqlite3-0/copyright")),
|
|
pkg.NewLicenseFromLocationsWithContext(ctx, "GPL-2+", file.NewLocation("/usr/share/doc/libsqlite3-0/copyright")),
|
|
pkg.NewLicenseFromLocationsWithContext(ctx, "GPL-2", file.NewLocation("/usr/share/doc/libsqlite3-0/copyright")),
|
|
),
|
|
Locations: file.NewLocationSet(
|
|
file.NewLocation("/var/lib/dpkg/status.d/libsqlite3-0").WithAnnotation(pkg.EvidenceAnnotationKey, pkg.PrimaryEvidenceAnnotation),
|
|
file.NewLocation("/var/lib/dpkg/status.d/libsqlite3-0.md5sums").WithAnnotation(pkg.EvidenceAnnotationKey, pkg.SupportingEvidenceAnnotation),
|
|
file.NewLocation("/var/lib/dpkg/status.d/libsqlite3-0.preinst").WithAnnotation(pkg.EvidenceAnnotationKey, pkg.SupportingEvidenceAnnotation),
|
|
file.NewLocation("/usr/share/doc/libsqlite3-0/copyright").WithAnnotation(pkg.EvidenceAnnotationKey, pkg.SupportingEvidenceAnnotation),
|
|
),
|
|
Type: pkg.DebPkg,
|
|
Metadata: pkg.DpkgDBEntry{
|
|
Package: "libsqlite3-0",
|
|
Source: "sqlite3",
|
|
Version: "3.34.1-3",
|
|
Architecture: "arm64",
|
|
Maintainer: "Laszlo Boszormenyi (GCS) <gcs@debian.org>",
|
|
InstalledSize: 1490,
|
|
Description: `SQLite 3 shared library
|
|
SQLite is a C library that implements an SQL database engine.
|
|
Programs that link with the SQLite library can have SQL database
|
|
access without running a separate RDBMS process.`,
|
|
Depends: []string{"libc6 (>= 2.29)"},
|
|
Files: []pkg.DpkgFileRecord{
|
|
{Path: "/usr/lib/aarch64-linux-gnu/libsqlite3.so.0.8.6", Digest: &file.Digest{
|
|
Algorithm: "md5",
|
|
Value: "e11d70c96979a1328ae4e7e50542782b",
|
|
}},
|
|
{Path: "/usr/share/doc/libsqlite3-0/README.Debian", Digest: &file.Digest{
|
|
Algorithm: "md5",
|
|
Value: "9d8facc2fa9d2df52f1c7cb4e5fa4741",
|
|
}},
|
|
{Path: "/usr/share/doc/libsqlite3-0/changelog.Debian.gz", Digest: &file.Digest{
|
|
Algorithm: "md5",
|
|
Value: "a58942e742f5056be0595e6ba69a323f",
|
|
}},
|
|
{Path: "/usr/share/doc/libsqlite3-0/changelog.gz", Digest: &file.Digest{
|
|
Algorithm: "md5",
|
|
Value: "52317be84c3ca44b7888c6921131e37d",
|
|
}},
|
|
{Path: "/usr/share/doc/libsqlite3-0/changelog.html.gz", Digest: &file.Digest{
|
|
Algorithm: "md5",
|
|
Value: "a856310354e6c8768e85b39ae838dd0a",
|
|
}},
|
|
{Path: "/usr/share/doc/libsqlite3-0/copyright", Digest: &file.Digest{
|
|
Algorithm: "md5",
|
|
Value: "be64db3e095486e5e105652c51199358",
|
|
}},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
c := NewDBCataloger()
|
|
pkgtest.NewCatalogTester().
|
|
WithImageResolver(t, tt.name).
|
|
IgnoreLocationLayer(). // this fixture can be rebuilt, thus the layer ID will change
|
|
Expects(tt.expected, nil).
|
|
TestCataloger(t, c)
|
|
})
|
|
}
|
|
}
|
|
|
|
func Test_CatalogerRelationships(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
fixture string
|
|
wantRelationships map[string][]string
|
|
}{
|
|
{
|
|
name: "relationships for coreutils",
|
|
fixture: "testdata/var/lib/dpkg/status.d/coreutils-relationships",
|
|
wantRelationships: map[string][]string{
|
|
"coreutils": {"libacl1", "libattr1", "libc6", "libgmp10", "libselinux1"},
|
|
"libacl1": {"libc6"},
|
|
"libattr1": {"libc6"},
|
|
"libc6": {"libgcc-s1"},
|
|
"libgcc-s1": {"gcc-12-base", "libc6"},
|
|
"libgmp10": {"libc6"},
|
|
"libpcre2-8-0": {"libc6"},
|
|
"libselinux1": {"libc6", "libpcre2-8-0"},
|
|
},
|
|
},
|
|
{
|
|
name: "relationships from dpkg example docs",
|
|
fixture: "testdata/var/lib/dpkg/status.d/doc-examples",
|
|
wantRelationships: map[string][]string{
|
|
"made-up-package-1": {"gnumach-dev", "hurd-dev", "kernel-headers-2.2.10"},
|
|
"made-up-package-2": {"liblua5.1-dev", "libluajit5.1-dev"},
|
|
"made-up-package-3": {"bar", "foo"},
|
|
// note that the "made-up-package-4" depends on "made-up-package-5" but not via the direct
|
|
// package name, but through the "provides" virtual package name "virtual-package-5".
|
|
"made-up-package-4": {"made-up-package-5"},
|
|
// note that though there is a "default-mta | mail-transport-agent | not-installed"
|
|
// dependency choice we raise up the packages that are installed for every choice.
|
|
// In this case that means that "default-mta" and "mail-transport-agent".
|
|
"mutt": {"default-mta", "libc6", "mail-transport-agent"},
|
|
},
|
|
},
|
|
{
|
|
name: "relationships for libpam-runtime",
|
|
fixture: "testdata/var/lib/dpkg/status.d/libpam-runtime",
|
|
wantRelationships: map[string][]string{
|
|
"libpam-runtime": {"cdebconf", "debconf-2.0", "debconf1", "debconf2", "libpam-modules"},
|
|
},
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
pkgs, relationships, err := NewDBCataloger().Catalog(context.Background(), file.NewMockResolverForPaths(tt.fixture))
|
|
require.NotEmpty(t, pkgs)
|
|
require.NotEmpty(t, relationships)
|
|
require.NoError(t, err)
|
|
|
|
if d := cmp.Diff(tt.wantRelationships, abstractRelationships(t, relationships)); d != "" {
|
|
t.Errorf("unexpected relationships (-want +got):\n%s", d)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestDpkgArchiveCataloger(t *testing.T) {
|
|
ctx := context.TODO()
|
|
tests := []struct {
|
|
name string
|
|
expected []pkg.Package
|
|
}{
|
|
{
|
|
name: "image-single-dpkg",
|
|
expected: []pkg.Package{
|
|
{
|
|
Name: "zlib1g",
|
|
Version: "1:1.3.dfsg-3.1ubuntu2.1",
|
|
FoundBy: "deb-archive-cataloger",
|
|
Locations: file.NewLocationSet(
|
|
file.NewLocation("/zlib1g.deb"),
|
|
),
|
|
Licenses: pkg.NewLicenseSet(
|
|
pkg.NewLicenseFromLocationsWithContext(ctx, "Zlib"),
|
|
),
|
|
PURL: "pkg:deb/zlib1g@1%3A1.3.dfsg-3.1ubuntu2.1?arch=amd64&upstream=zlib",
|
|
Type: pkg.DebPkg,
|
|
Metadata: pkg.DpkgArchiveEntry{
|
|
Package: "zlib1g",
|
|
Source: "zlib",
|
|
Version: "1:1.3.dfsg-3.1ubuntu2.1",
|
|
Architecture: "amd64",
|
|
Maintainer: "Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>",
|
|
InstalledSize: 163,
|
|
Description: `compression library - runtime
|
|
zlib is a library implementing the deflate compression method found
|
|
in gzip and PKZIP. This package includes the shared library.`,
|
|
Provides: []string{"libz1"},
|
|
Depends: []string{"libc6 (>= 2.14)"},
|
|
Files: []pkg.DpkgFileRecord{
|
|
{
|
|
Path: "/usr/lib/x86_64-linux-gnu/libz.so.1.3",
|
|
Digest: &file.Digest{Algorithm: "md5", Value: "4447b36fc5cd1b044f089553b4166f09"},
|
|
},
|
|
{
|
|
Path: "/usr/share/doc/zlib1g/changelog.Debian.gz",
|
|
Digest: &file.Digest{Algorithm: "md5", Value: "8b870c2e94c0cf780e2a65329cf11fdc"},
|
|
},
|
|
{
|
|
Path: "/usr/share/doc/zlib1g/copyright",
|
|
Digest: &file.Digest{Algorithm: "md5", Value: "d348307d5bf18267bcbada155a715a3e"},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
c := NewArchiveCataloger()
|
|
pkgtest.NewCatalogTester().
|
|
WithImageResolver(t, tt.name).
|
|
IgnoreLocationLayer(). // this fixture can be rebuilt, thus the layer ID will change
|
|
Expects(tt.expected, nil).
|
|
TestCataloger(t, c)
|
|
})
|
|
}
|
|
}
|
|
func TestCataloger_Globs(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
fixture string
|
|
expected []string
|
|
}{
|
|
{
|
|
name: "obtain db status files",
|
|
fixture: "testdata/glob-paths",
|
|
expected: []string{
|
|
"usr/lib/dpkg/status",
|
|
"var/lib/dpkg/status",
|
|
"usr/lib/dpkg/status.d/pkg-1.0",
|
|
"var/lib/dpkg/status.d/pkg-1.0",
|
|
"usr/lib/opkg/info/pkg-1.0.control",
|
|
"usr/lib/opkg/status",
|
|
"usr/lib/dpkg/info/libpam-runtime.conffiles",
|
|
"usr/lib/dpkg/info/libpam-runtime.md5sums",
|
|
"usr/share/doc/libpam-runtime/copyright",
|
|
},
|
|
},
|
|
}
|
|
|
|
for _, test := range tests {
|
|
t.Run(test.name, func(t *testing.T) {
|
|
pkgtest.NewCatalogTester().
|
|
FromDirectory(t, test.fixture).
|
|
ExpectsResolverContentQueries(test.expected).
|
|
TestCataloger(t, NewDBCataloger())
|
|
})
|
|
}
|
|
}
|